Re: [PATCH] nouveau: Do not leak in nv20_graph_create

2011-07-03 Thread Ben Skeggs
On Mon, Jul 4, 2011 at 12:39 AM, Marcin Slusarz wrote: > On Sun, Jul 03, 2011 at 01:21:55PM +0200, Jesper Juhl wrote: >> From: Jesper Juhl >> Subject: [PATCH] nouveau: Do not leak in nv20_graph_create >> >> If we return due to an unknown chipset in >> drivers/gpu/drm/nouveau/nv20_graph.c:nv20_gr

Re: [PATCH] nouveau: Do not leak in nv20_graph_create

2011-07-03 Thread Marcin Slusarz
On Sun, Jul 03, 2011 at 01:21:55PM +0200, Jesper Juhl wrote: > From: Jesper Juhl > Subject: [PATCH] nouveau: Do not leak in nv20_graph_create > > If we return due to an unknown chipset in > drivers/gpu/drm/nouveau/nv20_graph.c:nv20_graph_create() we'll leak the > memory allocated to 'pgraph'. >

Re: [PATCH] nouveau: Do not leak in nv20_graph_create

2011-07-03 Thread Jesper Juhl
On Sun, 3 Jul 2011, Jesper Juhl wrote: > On Sun, 3 Jul 2011, Paul Menzel wrote: > > > Dear Jesper, > > > > > > Am Sonntag, den 03.07.2011, 12:25 +0200 schrieb Jesper Juhl: > > > If we return due to an unknown chipset in > > > drivers/gpu/drm/nouveau/nv20_graph.c:nv20_graph_create() we'll leak

Re: [PATCH] nouveau: Do not leak in nv20_graph_create

2011-07-03 Thread Jesper Juhl
On Sun, 3 Jul 2011, Paul Menzel wrote: > Dear Jesper, > > > Am Sonntag, den 03.07.2011, 12:25 +0200 schrieb Jesper Juhl: > > If we return due to an unknown chipset in > > drivers/gpu/drm/nouveau/nv20_graph.c:nv20_graph_create() we'll leak the > > memory allocated to 'pgraph'. > > > > This pat

Re: [PATCH] nouveau: Do not leak in nv20_graph_create

2011-07-03 Thread Paul Menzel
Dear Jesper, Am Sonntag, den 03.07.2011, 12:25 +0200 schrieb Jesper Juhl: > If we return due to an unknown chipset in > drivers/gpu/drm/nouveau/nv20_graph.c:nv20_graph_create() we'll leak the > memory allocated to 'pgraph'. > > This patch should fix the leak and it also disambiguates the "PGRA