Re: [PATCH] mm: Fix compile error when CONFIG_SHMEM is not set

2025-06-04 Thread Steven Rostedt
On Wed, 04 Jun 2025 14:18:06 +0200 Thomas Hellström wrote: > Let me know if you want me to send a patch for that. This is a simple fix. I can send the patch and make sure it fixes my builds. Thanks, -- Steve

Re: [PATCH] mm: Fix compile error when CONFIG_SHMEM is not set

2025-06-04 Thread Thomas Hellström
On Wed, 2025-06-04 at 08:04 -0400, Steven Rostedt wrote: > On Wed, 4 Jun 2025 00:03:18 -0700 (PDT) > Hugh Dickins wrote: > > > I vote for the "select SHMEM", but Thomas and dri-devel and Linus > > should decide. > > I only tried "depends on SHMEM" which did not work, but it looks like > "select

Re: [PATCH] mm: Fix compile error when CONFIG_SHMEM is not set

2025-06-04 Thread Steven Rostedt
On Wed, 4 Jun 2025 00:03:18 -0700 (PDT) Hugh Dickins wrote: > I vote for the "select SHMEM", but Thomas and dri-devel and Linus > should decide. I only tried "depends on SHMEM" which did not work, but it looks like "select SHMEM" should. I prefer this solution too. Thanks, -- Steve

Re: [PATCH] mm: Fix compile error when CONFIG_SHMEM is not set

2025-06-04 Thread Hugh Dickins
Adding Thomas Hellström, father of ttm_backup_backup_page(): Steve doesn't have CONFIG_SHMEM=y, so now gets a build error because there's no shmem_writeout(); whereas before 6.16, backup_backup writeback would have oopsed on calling NULL ram_aops.writepage when CONFIG_SHMEM is not set. On Tue, 3 J

Re: [PATCH] mm: Fix compile error when CONFIG_SHMEM is not set

2025-06-03 Thread Steven Rostedt
On Tue, 3 Jun 2025 10:54:49 -0700 Linus Torvalds wrote: > On Tue, 3 Jun 2025 at 10:26, Steven Rostedt wrote: > > > > config DRM_TTM > > tristate > > - depends on DRM && MMU > > + depends on DRM && MMU && SHMEM > > Yeah, except I think you should just make it be > >

Re: [PATCH] mm: Fix compile error when CONFIG_SHMEM is not set

2025-06-03 Thread Linus Torvalds
On Tue, 3 Jun 2025 at 10:26, Steven Rostedt wrote: > > config DRM_TTM > tristate > - depends on DRM && MMU > + depends on DRM && MMU && SHMEM Yeah, except I think you should just make it be depends on DRM && SHMEM because SHMEM already depends on MMU. That said,

Re: [PATCH] mm: Fix compile error when CONFIG_SHMEM is not set

2025-06-03 Thread Steven Rostedt
[ Adding DRM folks ] On Tue, 3 Jun 2025 17:26:23 +0100 Matthew Wilcox wrote: > On Tue, Jun 03, 2025 at 10:29:59AM -0400, Steven Rostedt wrote: > > On Tue, 3 Jun 2025 01:02:36 -0700 (PDT) > > Hugh Dickins wrote: > > > > > Agreed that ramfs does not use swap, so calling swap_writepage() woul