Re: [PATCH] man: Fix typo and use $() for make expressions

2013-01-25 Thread Jesse Barnes
On Fri, 25 Jan 2013 16:54:11 +0100 David Herrmann wrote: > Hi Jesse > > On Fri, Jan 18, 2013 at 5:54 PM, Jesse Barnes > wrote: > > On Fri, 18 Jan 2013 17:01:59 +0100 > > David Herrmann wrote: > > > >> On Fri, Jan 18, 2013 at 5:00 PM, David Herrmann > >> wrote: > >> > Hi Thierry > >> > > >> >

Re: [PATCH] man: Fix typo and use $() for make expressions

2013-01-25 Thread David Herrmann
Hi Jesse On Fri, Jan 18, 2013 at 5:54 PM, Jesse Barnes wrote: > On Fri, 18 Jan 2013 17:01:59 +0100 > David Herrmann wrote: > >> On Fri, Jan 18, 2013 at 5:00 PM, David Herrmann >> wrote: >> > Hi Thierry >> > >> > On Fri, Jan 18, 2013 at 1:22 PM, Thierry Reding >> > wrote: >> >> Due to the typo,

Re: [PATCH] man: Fix typo and use $() for make expressions

2013-01-20 Thread Thierry Reding
On Fri, Jan 18, 2013 at 05:00:34PM +0100, David Herrmann wrote: [...] > Also ${} is pretty standard in makefiles, isn't it? The curly braces are allowed and valid syntax, but I haven't seen many uses of them. Historically only $() was a documented feature, while ${} was accepted as equivalent but

Re: [PATCH] man: Fix typo and use $() for make expressions

2013-01-20 Thread Mark Zhang
Thanks, David. After "sudo apt-get install docbook-xsl" and configure the libdrm with "--enable-manpages", I see the manpages generated. Mark On 01/20/2013 05:17 PM, David Herrmann wrote: > Hi Mark > > On Sun, Jan 20, 2013 at 7:39 AM, Mark Zhang wrote: >> Hi David: >> >> Sorry for jumping in. I

Re: [PATCH] man: Fix typo and use $() for make expressions

2013-01-20 Thread David Herrmann
Hi Mark On Sun, Jan 20, 2013 at 7:39 AM, Mark Zhang wrote: > Hi David: > > Sorry for jumping in. I pulled the ToT libdrm and it seems the manpages > will not be built("make html" does nothing), any suggestions? The manpages should be built automatically if you do "make". Or you can try "make -C

Re: [PATCH] man: Fix typo and use $() for make expressions

2013-01-19 Thread Mark Zhang
Hi David: Sorry for jumping in. I pulled the ToT libdrm and it seems the manpages will not be built("make html" does nothing), any suggestions? P.S: I've installed xsltproc. Mark On 01/19/2013 12:01 AM, David Herrmann wrote: > On Fri, Jan 18, 2013 at 5:00 PM, David Herrmann > wrote: >> Hi Thier

Re: [PATCH] man: Fix typo and use $() for make expressions

2013-01-18 Thread Jesse Barnes
On Fri, 18 Jan 2013 17:01:59 +0100 David Herrmann wrote: > On Fri, Jan 18, 2013 at 5:00 PM, David Herrmann > wrote: > > Hi Thierry > > > > On Fri, Jan 18, 2013 at 1:22 PM, Thierry Reding > > wrote: > >> Due to the typo, none of the .xml files would end up in the release > >> tarball and cause m

Re: [PATCH] man: Fix typo and use $() for make expressions

2013-01-18 Thread David Herrmann
On Fri, Jan 18, 2013 at 5:00 PM, David Herrmann wrote: > Hi Thierry > > On Fri, Jan 18, 2013 at 1:22 PM, Thierry Reding > wrote: >> Due to the typo, none of the .xml files would end up in the release >> tarball and cause make distcheck as well as builds from the tarball to >> fail. >> >> Using $(

Re: [PATCH] man: Fix typo and use $() for make expressions

2013-01-18 Thread David Herrmann
Hi Thierry On Fri, Jan 18, 2013 at 1:22 PM, Thierry Reding wrote: > Due to the typo, none of the .xml files would end up in the release > tarball and cause make distcheck as well as builds from the tarball to > fail. > > Using $() isn't strictly necessary but other variables and expressions > use