Re: [PATCH] glxproto: make GLX swap event struct match spec

2011-05-04 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/03/2011 02:08 PM, Jesse Barnes wrote: > On Tue, 3 May 2011 14:02:31 -0700 > Jesse Barnes wrote: > >> On Tue, 03 May 2011 13:54:38 -0700 >> Keith Packard wrote: >> >>> On Tue, 3 May 2011 12:21:24 -0700, Jesse Barnes >>> wrote: >>> We on

Re: [PATCH] glxproto: make GLX swap event struct match spec

2011-05-03 Thread Jesse Barnes
On Tue, 03 May 2011 14:15:30 -0700 Keith Packard wrote: > On Tue, 3 May 2011 14:08:58 -0700, Jesse Barnes > wrote: > > > Fixed version below. > > Reviewed-by: Keith Packard > > (assuming that the GLX protocol specification gets updated to match :-) Yeah, Ian is fixing up the padding there

Re: [PATCH] glxproto: make GLX swap event struct match spec

2011-05-03 Thread Keith Packard
On Tue, 3 May 2011 14:08:58 -0700, Jesse Barnes wrote: > Fixed version below. Reviewed-by: Keith Packard (assuming that the GLX protocol specification gets updated to match :-) -- keith.pack...@intel.com pgpc0zttIhtY3.pgp Description: PGP signature

Re: [PATCH] glxproto: make GLX swap event struct match spec

2011-05-03 Thread Jesse Barnes
On Tue, 3 May 2011 14:02:31 -0700 Jesse Barnes wrote: > On Tue, 03 May 2011 13:54:38 -0700 > Keith Packard wrote: > > > On Tue, 3 May 2011 12:21:24 -0700, Jesse Barnes > > wrote: > > > > > We only spec a 32 bit swap count, so drop the high sbc field. > > > > You're missing the explicit 16-

Re: [PATCH] glxproto: make GLX swap event struct match spec

2011-05-03 Thread Jesse Barnes
On Tue, 03 May 2011 13:54:38 -0700 Keith Packard wrote: > On Tue, 3 May 2011 12:21:24 -0700, Jesse Barnes > wrote: > > > We only spec a 32 bit swap count, so drop the high sbc field. > > You're missing the explicit 16-bit padding field after 'event_type' > > The documented encoding > http:/

Re: [PATCH] glxproto: make GLX swap event struct match spec

2011-05-03 Thread Keith Packard
On Tue, 3 May 2011 12:21:24 -0700, Jesse Barnes wrote: > We only spec a 32 bit swap count, so drop the high sbc field. You're missing the explicit 16-bit padding field after 'event_type' The documented encoding http://www.opengl.org/registry/specs/INTEL/swap_event.txt needs to be fixed to mat