Re: [PATCH] exynos: add C++ support to exynos_drmif header

2017-04-08 Thread Tobias Jakobi
Emil Velikov wrote: > FTR, only the installed headers (~50) need the extern C guard. > None of that is not a blocker for this patch, so I've just pushed it to > master. Thanks Emil. I'll see what I can do about the other ones. - Tobias > Thanks! > Emil > __

Re: [PATCH] exynos: add C++ support to exynos_drmif header

2017-04-08 Thread Emil Velikov
On 5 April 2017 at 17:23, Tobias Jakobi wrote: > Hello Eric, > > > Eric Engestrom wrote: >> On Wednesday, 2017-04-05 16:22:24 +0200, Tobias Jakobi wrote: >>> Add the usual extern "C" when compiling in C++ mode. >> >> Thanks, but why specifically this header? The other exynos/*.h headers >> also la

Re: [PATCH] exynos: add C++ support to exynos_drmif header

2017-04-05 Thread Tobias Jakobi
Hello Eric, Eric Engestrom wrote: > On Wednesday, 2017-04-05 16:22:24 +0200, Tobias Jakobi wrote: >> Add the usual extern "C" when compiling in C++ mode. > > Thanks, but why specifically this header? The other exynos/*.h headers > also lack the c++ mangling guard. I'm currently writing a small C

Re: [PATCH] exynos: add C++ support to exynos_drmif header

2017-04-05 Thread Eric Engestrom
On Wednesday, 2017-04-05 16:22:24 +0200, Tobias Jakobi wrote: > Add the usual extern "C" when compiling in C++ mode. Thanks, but why specifically this header? The other exynos/*.h headers also lack the c++ mangling guard. A quick grep shows that only 15/101 headers in libdrm have it. Can I intere