Re: [PATCH] drm: rework description of primary and cursor planes

2020-12-10 Thread Alex Deucher
On Thu, Dec 10, 2020 at 10:56 AM Daniel Vetter wrote: > > On Thu, Dec 10, 2020 at 4:45 PM Simon Ser wrote: > > On Wednesday, December 9th, 2020 at 8:40 PM, Daniel Vetter > > wrote: > > > > But it's not enough, can't have two CRTCs with the same primary plane. > > > > Well, > > > > I give up, i

Re: [PATCH] drm: rework description of primary and cursor planes

2020-12-10 Thread Simon Ser
On Thursday, December 10th, 2020 at 4:56 PM, Daniel Vetter wrote: > Huh so crtc are registered forward and planes backward? I guess adding > amd people. And yeah sounds like defacto you can't figure out which > primary plane goes to which crtc, and we just take whatever goes. > Maybe that strict

Re: [PATCH] drm: rework description of primary and cursor planes

2020-12-10 Thread Daniel Vetter
On Thu, Dec 10, 2020 at 4:45 PM Simon Ser wrote: > On Wednesday, December 9th, 2020 at 8:40 PM, Daniel Vetter > wrote: > > > But it's not enough, can't have two CRTCs with the same primary plane. > > > Well, > > > I give up, it's just simpler to use Daniel's criteria. > > > > Yeah, also with th

Re: [PATCH] drm: rework description of primary and cursor planes

2020-12-10 Thread Simon Ser
Additional note, I don't really want to add the same check for cursor planes, because I don't want to forbid a driver from having the CRTC without a cursor plane and the second CRTC with a cursor plane. I don't know if such heterogeneous hardware exists, but it sounds like something we should be ab

Re: [PATCH] drm: rework description of primary and cursor planes

2020-12-10 Thread Simon Ser
On Wednesday, December 9th, 2020 at 8:40 PM, Daniel Vetter wrote: > > But it's not enough, can't have two CRTCs with the same primary plane. Well, > > I give up, it's just simpler to use Daniel's criteria. > > Yeah, also with the validation check we'll now real quick if any driver > gets it wron

Re: [PATCH] drm: rework description of primary and cursor planes

2020-12-09 Thread Daniel Vetter
On Wed, Dec 09, 2020 at 04:35:31PM +, Simon Ser wrote: > On Wednesday, December 9th, 2020 at 5:02 PM, Daniel Vetter > wrote: > > > On Wed, 9 Dec 2020 01:42:23 +0100 > > Daniel Vetter wrote: > > > > > On Sun, Dec 06, 2020 at 04:34:15PM +, Simon Ser wrote: > > > > The previous wording cou

Re: [PATCH] drm: rework description of primary and cursor planes

2020-12-09 Thread Simon Ser
On Wednesday, December 9th, 2020 at 5:02 PM, Daniel Vetter wrote: > On Wed, 9 Dec 2020 01:42:23 +0100 > Daniel Vetter wrote: > > > On Sun, Dec 06, 2020 at 04:34:15PM +, Simon Ser wrote: > > > The previous wording could be understood by user-space evelopers as "a > > > primary/cursor plane i

Re: [PATCH] drm: rework description of primary and cursor planes

2020-12-09 Thread Simon Ser
On Wednesday, December 9th, 2020 at 5:02 PM, Daniel Vetter wrote: > On Wed, Dec 09, 2020 at 03:58:17PM +, Simon Ser wrote: > > Thanks for the review! > > > > On Wednesday, December 9th, 2020 at 1:42 AM, Daniel Vetter > > wrote: > > > > > I think maybe a follow up patch should document how

Re: [PATCH] drm: rework description of primary and cursor planes

2020-12-09 Thread Daniel Vetter
On Wed, Dec 09, 2020 at 03:58:17PM +, Simon Ser wrote: > Thanks for the review! > > On Wednesday, December 9th, 2020 at 1:42 AM, Daniel Vetter > wrote: > > > I think maybe a follow up patch should document how userspace should > > figure out how to line up the primary planes with the right

Re: [PATCH] drm: rework description of primary and cursor planes

2020-12-09 Thread Simon Ser
Thanks for the review! On Wednesday, December 9th, 2020 at 1:42 AM, Daniel Vetter wrote: > I think maybe a follow up patch should document how userspace should > figure out how to line up the primary planes with the right crtcs (if it > wishes to know that information, it's not super useful asi

Re: [PATCH] drm: rework description of primary and cursor planes

2020-12-09 Thread Pekka Paalanen
On Wed, 9 Dec 2020 01:42:23 +0100 Daniel Vetter wrote: > On Sun, Dec 06, 2020 at 04:34:15PM +, Simon Ser wrote: > > The previous wording could be understood by user-space evelopers as "a > > primary/cursor plane is only compatible with a single CRTC" [1]. > > > > Reword the planes descriptio

Re: [PATCH] drm: rework description of primary and cursor planes

2020-12-08 Thread Daniel Vetter
On Sun, Dec 06, 2020 at 04:34:15PM +, Simon Ser wrote: > The previous wording could be understood by user-space evelopers as "a > primary/cursor plane is only compatible with a single CRTC" [1]. > > Reword the planes description to make it clear the DRM-internal > drm_crtc.primary and drm_crtc