Re: [PATCH] drm: rcar-du: Setup planes before enabling CRTC to avoid flicker

2017-07-17 Thread Kieran Bingham
Hi Maxime, On 17/07/17 07:32, Maxime Ripard wrote: > On Thu, Jul 13, 2017 at 05:25:08PM +0100, Kieran Bingham wrote: > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c > b/drivers/gpu/drm/rcar-du/rcar_du_kms.c > index 82b978a5dae6..c2f382feca07 100644 > --- a/drivers/gpu/drm/rca

Re: [PATCH] drm: rcar-du: Setup planes before enabling CRTC to avoid flicker

2017-07-16 Thread Maxime Ripard
On Thu, Jul 13, 2017 at 05:25:08PM +0100, Kieran Bingham wrote: > >>> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c > >>> b/drivers/gpu/drm/rcar-du/rcar_du_kms.c > >>> index 82b978a5dae6..c2f382feca07 100644 > >>> --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c > >>> +++ b/drivers/gpu/drm/rcar-du

Re: [PATCH] drm: rcar-du: Setup planes before enabling CRTC to avoid flicker

2017-07-13 Thread Kieran Bingham
On 13/07/17 16:51, Kieran Bingham wrote: > Hi Laurent, > > I've just seen Maxime's latest series "[PATCH 0/4] drm/sun4i: Fix a register > access bug" and it relates directly to a comment I had in this patch: > > On 12/07/17 17:35, Kieran Bingham wrote: >> Hi Laurent, >> >> On 28/06/17 19:50, Laur

Re: [PATCH] drm: rcar-du: Setup planes before enabling CRTC to avoid flicker

2017-07-13 Thread Kieran Bingham
Hi Laurent, I've just seen Maxime's latest series "[PATCH 0/4] drm/sun4i: Fix a register access bug" and it relates directly to a comment I had in this patch: On 12/07/17 17:35, Kieran Bingham wrote: > Hi Laurent, > > On 28/06/17 19:50, Laurent Pinchart wrote: >> Commit 52055bafa1ff ("drm: rcar-

Re: [PATCH] drm: rcar-du: Setup planes before enabling CRTC to avoid flicker

2017-07-13 Thread Laurent Pinchart
Hi Kieran, On Wednesday 12 Jul 2017 17:35:53 Kieran Bingham wrote: > On 28/06/17 19:50, Laurent Pinchart wrote: > > Commit 52055bafa1ff ("drm: rcar-du: Move plane commit code from CRTC > > start to CRTC resume") changed the order of the plane commit and CRTC > > enable operations to accommodate th

Re: [PATCH] drm: rcar-du: Setup planes before enabling CRTC to avoid flicker

2017-07-13 Thread Laurent Pinchart
Hi Kieran, On Thursday 13 Jul 2017 16:51:18 Kieran Bingham wrote: > Hi Laurent, > > I've just seen Maxime's latest series "[PATCH 0/4] drm/sun4i: Fix a register > access bug" and it relates directly to a comment I had in this patch: > On 12/07/17 17:35, Kieran Bingham wrote: > > > On 28/06/17 19:

Re: [PATCH] drm: rcar-du: Setup planes before enabling CRTC to avoid flicker

2017-07-12 Thread Kieran Bingham
Hi Laurent, On 28/06/17 19:50, Laurent Pinchart wrote: > Commit 52055bafa1ff ("drm: rcar-du: Move plane commit code from CRTC > start to CRTC resume") changed the order of the plane commit and CRTC > enable operations to accommodate the runtime PM requirements. However, > this introduced corruptio

Re: [PATCH] drm: rcar-du: Setup planes before enabling CRTC to avoid flicker

2017-06-28 Thread Laurent Pinchart
Hi Geert, On Wednesday 28 Jun 2017 20:52:53 Geert Uytterhoeven wrote: > On Wed, Jun 28, 2017 at 8:50 PM, Laurent Pinchart wrote: > > Commit 52055bafa1ff ("drm: rcar-du: Move plane commit code from CRTC > > start to CRTC resume") changed the order of the plane commit and CRTC > > enable operations

Re: [PATCH] drm: rcar-du: Setup planes before enabling CRTC to avoid flicker

2017-06-28 Thread Geert Uytterhoeven
On Wed, Jun 28, 2017 at 8:50 PM, Laurent Pinchart wrote: > Commit 52055bafa1ff ("drm: rcar-du: Move plane commit code from CRTC > start to CRTC resume") changed the order of the plane commit and CRTC > enable operations to accommodate the runtime PM requirements. However, > this introduced corrupt