Re: [PATCH] drm: mxsfb: Fix NULL pointer dereference crash on unload

2021-10-19 Thread Daniel Vetter
On Sun, Oct 17, 2021 at 10:05 PM Marek Vasut wrote: > > On 10/17/21 7:52 PM, Sam Ravnborg wrote: > > Hi Marek, > > > > On Wed, Sep 08, 2021 at 08:24:20PM +0200, Daniel Vetter wrote: > >> On Tue, Sep 07, 2021 at 04:49:00AM +0200, Marek Vasut wrote: > >>> The mxsfb->crtc.funcs may already be NULL wh

Re: [PATCH] drm: mxsfb: Fix NULL pointer dereference crash on unload

2021-10-17 Thread Marek Vasut
On 10/17/21 7:52 PM, Sam Ravnborg wrote: Hi Marek, On Wed, Sep 08, 2021 at 08:24:20PM +0200, Daniel Vetter wrote: On Tue, Sep 07, 2021 at 04:49:00AM +0200, Marek Vasut wrote: The mxsfb->crtc.funcs may already be NULL when unloading the driver, in which case calling mxsfb_irq_disable() via drm_

Re: [PATCH] drm: mxsfb: Fix NULL pointer dereference crash on unload

2021-10-17 Thread Sam Ravnborg
Hi Marek, On Wed, Sep 08, 2021 at 08:24:20PM +0200, Daniel Vetter wrote: > On Tue, Sep 07, 2021 at 04:49:00AM +0200, Marek Vasut wrote: > > The mxsfb->crtc.funcs may already be NULL when unloading the driver, > > in which case calling mxsfb_irq_disable() via drm_irq_uninstall() from > > mxsfb_unlo

Re: [PATCH] drm: mxsfb: Fix NULL pointer dereference crash on unload

2021-10-17 Thread Sam Ravnborg
Hi Marek, On Sat, Oct 16, 2021 at 11:04:46PM +0200, Marek Vasut wrote: > The mxsfb->crtc.funcs may already be NULL when unloading the driver, > in which case calling mxsfb_irq_disable() via drm_irq_uninstall() from > mxsfb_unload() leads to NULL pointer dereference. > > Since all we care about is

Re: [PATCH] drm: mxsfb: Fix NULL pointer dereference crash on unload

2021-09-08 Thread Marek Vasut
On 9/8/21 8:24 PM, Daniel Vetter wrote: On Tue, Sep 07, 2021 at 04:49:00AM +0200, Marek Vasut wrote: The mxsfb->crtc.funcs may already be NULL when unloading the driver, in which case calling mxsfb_irq_disable() via drm_irq_uninstall() from mxsfb_unload() leads to NULL pointer dereference. Sinc

Re: [PATCH] drm: mxsfb: Fix NULL pointer dereference crash on unload

2021-09-08 Thread Daniel Vetter
On Tue, Sep 07, 2021 at 04:49:00AM +0200, Marek Vasut wrote: > The mxsfb->crtc.funcs may already be NULL when unloading the driver, > in which case calling mxsfb_irq_disable() via drm_irq_uninstall() from > mxsfb_unload() leads to NULL pointer dereference. > > Since all we care about is masking th