Re: [PATCH] drm: fix out-of-bounds access with short VSDB blocks

2019-07-23 Thread Steven Price
On 22/07/2019 15:38, Simon Ser wrote: > From: Simon Ser > > The VSDB parsing code contains a few len >= N checks, accessing db[N] on > success. However if len == N, db[N] is out-of-bounds. I'm not familiar with VSDB parsing, but there's a comment before the function: > * @len: length of the CE

Re: [PATCH] drm: fix out-of-bounds access with short VSDB blocks

2019-07-22 Thread Sean Paul
On Mon, Jul 22, 2019 at 02:38:34PM +, Simon Ser wrote: > From: Simon Ser > > The VSDB parsing code contains a few len >= N checks, accessing db[N] on > success. However if len == N, db[N] is out-of-bounds. > > This commit changes the checks to test for len > N. I'm not familiar with this at

Re: [PATCH] drm: fix out-of-bounds access with short VSDB blocks

2019-07-22 Thread Ser, Simon
On Mon, 2019-07-22 at 14:38 +, Simon Ser wrote: > From: Simon Ser > > The VSDB parsing code contains a few len >= N checks, accessing db[N] on > success. However if len == N, db[N] is out-of-bounds. > > This commit changes the checks to test for len > N. > > Signed-off-by: Simon Ser Bleh,