Re: [PATCH] drm: drm_gem.h: Add explicit includes for DEFINE_DRM_GEM_FOPS

2022-05-05 Thread Daniel Vetter
On Wed, May 04, 2022 at 07:58:38AM -0600, Jeffrey Hugo wrote: > On 5/4/2022 3:38 AM, Daniel Vetter wrote: > > On Mon, May 02, 2022 at 06:41:39PM +0300, Jani Nikula wrote: > > > On Fri, 29 Apr 2022, Jeffrey Hugo wrote: > > > > DEFINE_DRM_GEM_FOPS() references drm functions from other headers. For

Re: [PATCH] drm: drm_gem.h: Add explicit includes for DEFINE_DRM_GEM_FOPS

2022-05-04 Thread Jeffrey Hugo
On 5/4/2022 3:38 AM, Daniel Vetter wrote: On Mon, May 02, 2022 at 06:41:39PM +0300, Jani Nikula wrote: On Fri, 29 Apr 2022, Jeffrey Hugo wrote: DEFINE_DRM_GEM_FOPS() references drm functions from other headers. For example drm_open() is defined in drm_file.h and drm_ioctl() is defined in drm_

Re: [PATCH] drm: drm_gem.h: Add explicit includes for DEFINE_DRM_GEM_FOPS

2022-05-04 Thread Daniel Vetter
On Mon, May 02, 2022 at 06:41:39PM +0300, Jani Nikula wrote: > On Fri, 29 Apr 2022, Jeffrey Hugo wrote: > > DEFINE_DRM_GEM_FOPS() references drm functions from other headers. For > > example drm_open() is defined in drm_file.h and drm_ioctl() is defined > > in drm_ioctl.h. Since drm_gem.h doesn'

Re: [PATCH] drm: drm_gem.h: Add explicit includes for DEFINE_DRM_GEM_FOPS

2022-05-02 Thread Jani Nikula
On Fri, 29 Apr 2022, Jeffrey Hugo wrote: > DEFINE_DRM_GEM_FOPS() references drm functions from other headers. For > example drm_open() is defined in drm_file.h and drm_ioctl() is defined > in drm_ioctl.h. Since drm_gem.h doesn't include these headers, it > relies on an implicit include from the