Re: [PATCH] drm: Some ocd in drm_file.c

2019-05-09 Thread Daniel Vetter
On Thu, May 02, 2019 at 03:07:20PM +0100, Chris Wilson wrote: > Quoting Daniel Vetter (2019-05-02 14:56:03) > > Move the open helper around to avoid the forward decl, and give > > drm_setup a drm_legacy_ prefix since it's all legacy stuff in there. > > > > v2: Move drm_legacy_setup into drm_legacy

Re: [PATCH] drm: Some ocd in drm_file.c

2019-05-02 Thread Chris Wilson
Quoting Daniel Vetter (2019-05-02 14:56:03) > Move the open helper around to avoid the forward decl, and give > drm_setup a drm_legacy_ prefix since it's all legacy stuff in there. > > v2: Move drm_legacy_setup into drm_legacy_misc.c (Chris). The > counterpart in the form of drm_legacy_dev_reinit

Re: [PATCH] drm: Some ocd in drm_file.c

2019-05-02 Thread Chris Wilson
Quoting Daniel Vetter (2019-05-02 08:27:27) > +static int drm_legacy_setup(struct drm_device * dev) > +{ > + int ret; > + > + if (dev->driver->firstopen && > + drm_core_check_feature(dev, DRIVER_LEGACY)) { > + ret = dev->driver->firstopen(dev); > +