Re: [PATCH] drm: Convert drm_atomic_helper_suspend/resume()

2018-08-13 Thread Souptick Joarder
Hi Laurent, On Mon, Aug 13, 2018 at 10:46 PM, Liviu Dudau wrote: > On Thu, Aug 02, 2018 at 03:25:24PM +0530, Souptick Joarder wrote: >> On Wed, Aug 1, 2018 at 12:11 AM, Souptick Joarder >> wrote: >> > On Tue, Jul 31, 2018 at 4:04 PM, Liviu Dudau wrote: >> >> Hi Souptick, >> >> >> >> On Tue, Ju

Re: [PATCH] drm: Convert drm_atomic_helper_suspend/resume()

2018-08-13 Thread Laurent Pinchart
Hi Souptick, On Monday, 13 August 2018 21:51:31 EEST Souptick Joarder wrote: > On Mon, Aug 13, 2018 at 10:46 PM, Liviu Dudau wrote: > > On Thu, Aug 02, 2018 at 03:25:24PM +0530, Souptick Joarder wrote: > >> On Wed, Aug 1, 2018 at 12:11 AM, Souptick Joarder wrote: > >>> On Tue, Jul 31, 2018 at 4:0

Re: [PATCH] drm: Convert drm_atomic_helper_suspend/resume()

2018-08-13 Thread Liviu Dudau
On Thu, Aug 02, 2018 at 03:25:24PM +0530, Souptick Joarder wrote: > On Wed, Aug 1, 2018 at 12:11 AM, Souptick Joarder > wrote: > > On Tue, Jul 31, 2018 at 4:04 PM, Liviu Dudau wrote: > >> Hi Souptick, > >> > >> On Tue, Jul 31, 2018 at 12:31:37AM +0530, Souptick Joarder wrote: > >>> convert drm_a

Re: [PATCH] drm: Convert drm_atomic_helper_suspend/resume()

2018-08-03 Thread Souptick Joarder
On Wed, Aug 1, 2018 at 12:11 AM, Souptick Joarder wrote: > On Tue, Jul 31, 2018 at 4:04 PM, Liviu Dudau wrote: >> Hi Souptick, >> >> On Tue, Jul 31, 2018 at 12:31:37AM +0530, Souptick Joarder wrote: >>> convert drm_atomic_helper_suspend/resume() to use >>> drm_mode_config_helper_suspend/resume().

Re: [PATCH] drm: Convert drm_atomic_helper_suspend/resume()

2018-08-02 Thread Souptick Joarder
On Tue, Jul 31, 2018 at 4:04 PM, Liviu Dudau wrote: > Hi Souptick, > > On Tue, Jul 31, 2018 at 12:31:37AM +0530, Souptick Joarder wrote: >> convert drm_atomic_helper_suspend/resume() to use >> drm_mode_config_helper_suspend/resume(). >> >> With this conversion, drm_fbdev_cma_set_suspend_unlocked()

Re: [PATCH] drm: Convert drm_atomic_helper_suspend/resume()

2018-07-31 Thread Liviu Dudau
Hi Souptick, On Tue, Jul 31, 2018 at 12:31:37AM +0530, Souptick Joarder wrote: > convert drm_atomic_helper_suspend/resume() to use > drm_mode_config_helper_suspend/resume(). > > With this conversion, drm_fbdev_cma_set_suspend_unlocked() > will left with no consumer. So this function can be remove

Re: [PATCH] drm: Convert drm_atomic_helper_suspend/resume()

2018-07-31 Thread Souptick Joarder
> If you further remove the suspend_state field from the rcar_du_device > structure, you'll get my > > Reviewed-by: Laurent Pinchart > Sorry, missed it. >> - >> - return 0; >> + return drm_mode_config_helper_suspend(rcdu->ddev); >> } >> >> static int rcar_du_pm_resume(struct device *de

Re: [PATCH] drm: Convert drm_atomic_helper_suspend/resume()

2018-07-30 Thread Laurent Pinchart
Hi Souptick, Thank you for the patch. On Monday, 30 July 2018 22:01:37 EEST Souptick Joarder wrote: > convert drm_atomic_helper_suspend/resume() to use > drm_mode_config_helper_suspend/resume(). > > With this conversion, drm_fbdev_cma_set_suspend_unlocked() > will left with no consumer. So this