RE: [PATCH] drm/vmwgfx: fix memory corruption with legacy/sou connectors

2018-01-18 Thread Deepak Singh Rawat
Thanks Rob for finding this one. Reviewed-by: Deepak Rawat > From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf > Of Rob Clark > Sent: Wednesday, January 17, 2018 7:16 AM > To: dri-devel@lists.freedesktop.org > Cc: Thomas Hellstrom ; Rob Clark > ; David Airlie ; linux- >

Re: [PATCH] drm/vmwgfx: fix memory corruption with legacy/sou connectors

2018-01-17 Thread Thomas Hellstrom
On 01/17/2018 04:16 PM, Rob Clark wrote: From: Rob Clark It looks like in all cases 'struct vmw_connector_state' is used. But only in stdu connectors, was atomic_{duplicate,destroy}_state() properly subclassed. Leading to writes beyond the end of the allocated connector state block and all so