Re: [PATCH] drm/vmwgfx: Propagate error on failed ioctl

2022-03-28 Thread Philipp Sieweck
Hi Zack! > > I'd just break apart the condition above rather than have two if ret != > 0. What apps do you see glitches in as a result of this? Can you > reproduce it? > There are many apps I can use to trigger this drm error. It occurs more often on a Wayland-based desktop than on X11. While loo

Re: [PATCH] drm/vmwgfx: Propagate error on failed ioctl

2022-03-25 Thread Zack Rusin
On Sun, 2022-03-13 at 06:06 +0100, Philipp Sieweck wrote: > The cases of vmw_user_bo_synccpu_grab failing with -ERESTARTSYS or - > EBUSY > are handled in vmw_user_bo_synccpu_ioctl by not printing an error > message. > However, the error value gets discarded, indicating success. This > leads > to re

Re: [PATCH] drm/vmwgfx: Propagate error on failed ioctl

2022-03-25 Thread Javier Martinez Canillas
Hello Philipp, On 3/13/22 06:06, Philipp Sieweck wrote: > The cases of vmw_user_bo_synccpu_grab failing with -ERESTARTSYS or -EBUSY > are handled in vmw_user_bo_synccpu_ioctl by not printing an error message. > However, the error value gets discarded, indicating success. This leads > to rendering