Re: [PATCH] drm/vmwgfx: Add tracepoints

2024-09-06 Thread Zack Rusin
On Fri, Sep 6, 2024 at 11:26 AM Ian Forbes wrote: > > On Thu, Sep 5, 2024 at 10:59 PM Zack Rusin wrote: > > > > > > In general it looks good but what's the reason for the submit_time? > > > > z > > So you can get an approximate time of how long each command buffer takes. > You can then use it to

Re: [PATCH] drm/vmwgfx: Add tracepoints

2024-09-06 Thread Ian Forbes
On Thu, Sep 5, 2024 at 10:59 PM Zack Rusin wrote: > > > In general it looks good but what's the reason for the submit_time? > > z So you can get an approximate time of how long each command buffer takes. You can then use it to construct a histogram or look for outliers using bpftrace. Useful when

Re: [PATCH] drm/vmwgfx: Add tracepoints

2024-09-05 Thread Zack Rusin
On Thu, Sep 5, 2024 at 2:17 PM Ian Forbes wrote: > > Adds the necessary files to create tracepoints for the vmwgfx driver. > > Adds a single tracepoint for command buffer completion. This tracepoint > can be used to time command buffer execution time and to decode command > buffer errors. The subm