Re: [PATCH] drm/vboxvideo: Make structure vbox_fb_helper_funcs constant

2019-08-18 Thread Hans de Goede
Hi all, On 14-08-19 19:36, Hans de Goede wrote: Hi, On 14-08-19 19:26, Daniel Vetter wrote: On Tue, Aug 13, 2019 at 09:57:19AM +0200, Hans de Goede wrote: Hi, On 13-08-19 08:25, Nishka Dasgupta wrote: The static structure vbox_fb_helper_funcs, of type drm_fb_helper_funcs, is used only when

Re: [PATCH] drm/vboxvideo: Make structure vbox_fb_helper_funcs constant

2019-08-14 Thread Daniel Vetter
On Wed, Aug 14, 2019 at 08:42:27PM +0200, Sam Ravnborg wrote: > On Wed, Aug 14, 2019 at 07:51:37PM +0200, Daniel Vetter wrote: > > On Wed, Aug 14, 2019 at 07:36:55PM +0200, Hans de Goede wrote: > > > Hi, > > > > > > On 14-08-19 19:26, Daniel Vetter wrote: > > > > On Tue, Aug 13, 2019 at 09:57:19AM

Re: [PATCH] drm/vboxvideo: Make structure vbox_fb_helper_funcs constant

2019-08-14 Thread Sam Ravnborg
On Wed, Aug 14, 2019 at 07:51:37PM +0200, Daniel Vetter wrote: > On Wed, Aug 14, 2019 at 07:36:55PM +0200, Hans de Goede wrote: > > Hi, > > > > On 14-08-19 19:26, Daniel Vetter wrote: > > > On Tue, Aug 13, 2019 at 09:57:19AM +0200, Hans de Goede wrote: > > > > Hi, > > > > > > > > On 13-08-19 08:2

Re: [PATCH] drm/vboxvideo: Make structure vbox_fb_helper_funcs constant

2019-08-14 Thread Daniel Vetter
On Wed, Aug 14, 2019 at 07:36:55PM +0200, Hans de Goede wrote: > Hi, > > On 14-08-19 19:26, Daniel Vetter wrote: > > On Tue, Aug 13, 2019 at 09:57:19AM +0200, Hans de Goede wrote: > > > Hi, > > > > > > On 13-08-19 08:25, Nishka Dasgupta wrote: > > > > The static structure vbox_fb_helper_funcs, of

Re: [PATCH] drm/vboxvideo: Make structure vbox_fb_helper_funcs constant

2019-08-14 Thread Hans de Goede
Hi, On 14-08-19 19:26, Daniel Vetter wrote: On Tue, Aug 13, 2019 at 09:57:19AM +0200, Hans de Goede wrote: Hi, On 13-08-19 08:25, Nishka Dasgupta wrote: The static structure vbox_fb_helper_funcs, of type drm_fb_helper_funcs, is used only when it is passed as the third argument to drm_fb_helpe

Re: [PATCH] drm/vboxvideo: Make structure vbox_fb_helper_funcs constant

2019-08-14 Thread Daniel Vetter
On Tue, Aug 13, 2019 at 09:57:19AM +0200, Hans de Goede wrote: > Hi, > > On 13-08-19 08:25, Nishka Dasgupta wrote: > > The static structure vbox_fb_helper_funcs, of type drm_fb_helper_funcs, > > is used only when it is passed as the third argument to > > drm_fb_helper_fbdev_setup(), which does not

Re: [PATCH] drm/vboxvideo: Make structure vbox_fb_helper_funcs constant

2019-08-13 Thread Hans de Goede
Hi, On 13-08-19 08:25, Nishka Dasgupta wrote: The static structure vbox_fb_helper_funcs, of type drm_fb_helper_funcs, is used only when it is passed as the third argument to drm_fb_helper_fbdev_setup(), which does not modify it. Hence make it constant to protect it from unintended modifications.