Re: [PATCH] drm/tegra: Remove existing framebuffer only if we support display

2023-09-07 Thread Javier Martinez Canillas
Thomas Zimmermann writes: [...] >> That's a good point. However I recall from earlier attempts at doing >> something like this in Nouveau (although this is now very long ago) that >> it's not very easy. The problem, as I recall, is that the driver is a >> singleton, so we would essentially be su

Re: [PATCH] drm/tegra: Remove existing framebuffer only if we support display

2023-09-07 Thread Thomas Zimmermann
Hi Am 07.09.23 um 10:03 schrieb Thierry Reding: On Thu, Aug 31, 2023 at 10:04:29AM +0200, Daniel Vetter wrote: On Thu, 31 Aug 2023 at 08:33, Mikko Perttunen wrote: On 8/30/23 13:19, Thomas Zimmermann wrote: Hi Am 25.08.23 um 15:22 schrieb Thierry Reding: From: Thierry Reding Tegra DRM d

Re: [PATCH] drm/tegra: Remove existing framebuffer only if we support display

2023-09-07 Thread Javier Martinez Canillas
Thierry Reding writes: Hello Thierry, > On Wed, Aug 30, 2023 at 08:13:04AM +0200, Javier Martinez Canillas wrote: [...] >> I also wonder if is worth to move the drm_num_crtcs() function from >> drivers/gpu/drm/drm_crtc.c to include/drm/drm_crtc.h and use that helper >> instead? > > I've been l

Re: [PATCH] drm/tegra: Remove existing framebuffer only if we support display

2023-09-07 Thread Thierry Reding
On Thu, Aug 31, 2023 at 10:04:29AM +0200, Daniel Vetter wrote: > On Thu, 31 Aug 2023 at 08:33, Mikko Perttunen wrote: > > > > On 8/30/23 13:19, Thomas Zimmermann wrote: > > > Hi > > > > > > Am 25.08.23 um 15:22 schrieb Thierry Reding: > > >> From: Thierry Reding > > >> > > >> Tegra DRM doesn't su

Re: [PATCH] drm/tegra: Remove existing framebuffer only if we support display

2023-09-07 Thread Thierry Reding
On Wed, Aug 30, 2023 at 08:13:04AM +0200, Javier Martinez Canillas wrote: > Thierry Reding writes: > > Hello Thierry, > > > From: Thierry Reding > > > > Tegra DRM doesn't support display on Tegra234 and later, so make sure > > not to remove any existing framebuffers in that case. > > > > I see

Re: [PATCH] drm/tegra: Remove existing framebuffer only if we support display

2023-08-31 Thread Daniel Vetter
On Thu, 31 Aug 2023 at 08:33, Mikko Perttunen wrote: > > On 8/30/23 13:19, Thomas Zimmermann wrote: > > Hi > > > > Am 25.08.23 um 15:22 schrieb Thierry Reding: > >> From: Thierry Reding > >> > >> Tegra DRM doesn't support display on Tegra234 and later, so make sure > >> not to remove any existing

Re: [PATCH] drm/tegra: Remove existing framebuffer only if we support display

2023-08-30 Thread Mikko Perttunen
On 8/30/23 13:19, Thomas Zimmermann wrote: Hi Am 25.08.23 um 15:22 schrieb Thierry Reding: From: Thierry Reding Tegra DRM doesn't support display on Tegra234 and later, so make sure not to remove any existing framebuffers in that case. Signed-off-by: Thierry Reding ---   drivers/gpu/drm/teg

Re: [PATCH] drm/tegra: Remove existing framebuffer only if we support display

2023-08-30 Thread Thomas Zimmermann
Hi Am 25.08.23 um 15:22 schrieb Thierry Reding: From: Thierry Reding Tegra DRM doesn't support display on Tegra234 and later, so make sure not to remove any existing framebuffers in that case. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/drm.c | 8 +--- 1 file changed, 5 in

Re: [PATCH] drm/tegra: Remove existing framebuffer only if we support display

2023-08-29 Thread Javier Martinez Canillas
Thierry Reding writes: Hello Thierry, > From: Thierry Reding > > Tegra DRM doesn't support display on Tegra234 and later, so make sure > not to remove any existing framebuffers in that case. > I see, this makes sense to me. Acked-by: Javier Martinez Canillas A couple of comments below thoug