Re: [PATCH] drm/shmem-helpers: Simplify dma-buf importing

2020-05-29 Thread Boris Brezillon
On Fri, 29 May 2020 16:05:42 +0200 Daniel Vetter wrote: > - Ditch the ->pages array > - Make it a private gem bo, which means no shmem object, which means > fireworks if anyone calls drm_gem_object_get_pages. But we've just > made sure that's all covered. > > v2: Rebase > > v3: I forgot to

Re: [PATCH] drm/shmem-helpers: Simplify dma-buf importing

2020-05-29 Thread Boris Brezillon
On Wed, 20 May 2020 20:02:32 +0200 Daniel Vetter wrote: > @@ -695,36 +702,16 @@ drm_gem_shmem_prime_import_sg_table(struct drm_device > *dev, > struct sg_table *sgt) > { > size_t size = PAGE_ALIGN(attach->dmabuf->size); > - size_t npages = size >> PA

Re: [PATCH] drm/shmem-helpers: Simplify dma-buf importing

2020-05-29 Thread Boris Brezillon
On Fri, 29 May 2020 15:34:28 +0200 Boris Brezillon wrote: > Hi Daniel, > > On Wed, 20 May 2020 20:02:32 +0200 > Daniel Vetter wrote: > > > - Ditch the ->pages array > > - Make it a private gem bo, which means no shmem object, which means > > fireworks if anyone calls drm_gem_object_get_pages

Re: [PATCH] drm/shmem-helpers: Simplify dma-buf importing

2020-05-29 Thread Boris Brezillon
Hi Daniel, On Wed, 20 May 2020 20:02:32 +0200 Daniel Vetter wrote: > - Ditch the ->pages array > - Make it a private gem bo, which means no shmem object, which means > fireworks if anyone calls drm_gem_object_get_pages. But we've just > made sure that's all covered. > > v2: Rebase > > Acke