Re: [PATCH] drm/sched: Discourage usage of separate workqueues

2025-06-06 Thread Simona Vetter
On Wed, Jun 04, 2025 at 10:10:21AM -0700, Matthew Brost wrote: > On Wed, Jun 04, 2025 at 06:53:44PM +0200, Danilo Krummrich wrote: > > On Wed, Jun 04, 2025 at 09:45:00AM -0700, Matthew Brost wrote: > > > On Wed, Jun 04, 2025 at 05:07:15PM +0200, Simona Vetter wrote: > > > > We should definitely doc

Re: [PATCH] drm/sched: Discourage usage of separate workqueues

2025-06-05 Thread Philipp Stanner
On Wed, 2025-06-04 at 17:07 +0200, Simona Vetter wrote: > On Wed, Jun 04, 2025 at 11:41:25AM +0200, Christian König wrote: > > On 6/4/25 10:16, Philipp Stanner wrote: > > > struct drm_sched_init_args provides the possibility of letting > > > the > > > scheduler use user-controlled workqueues, inste

Re: [PATCH] drm/sched: Discourage usage of separate workqueues

2025-06-04 Thread Matthew Brost
On Wed, Jun 04, 2025 at 06:53:44PM +0200, Danilo Krummrich wrote: > On Wed, Jun 04, 2025 at 09:45:00AM -0700, Matthew Brost wrote: > > On Wed, Jun 04, 2025 at 05:07:15PM +0200, Simona Vetter wrote: > > > We should definitely document this trick better though, I didn't find any > > > place where tha

Re: [PATCH] drm/sched: Discourage usage of separate workqueues

2025-06-04 Thread Danilo Krummrich
On Wed, Jun 04, 2025 at 09:45:00AM -0700, Matthew Brost wrote: > On Wed, Jun 04, 2025 at 05:07:15PM +0200, Simona Vetter wrote: > > We should definitely document this trick better though, I didn't find any > > place where that was documented. > > This is a good idea. I think - and I also mentione

Re: [PATCH] drm/sched: Discourage usage of separate workqueues

2025-06-04 Thread Matthew Brost
On Wed, Jun 04, 2025 at 05:07:15PM +0200, Simona Vetter wrote: > On Wed, Jun 04, 2025 at 11:41:25AM +0200, Christian König wrote: > > On 6/4/25 10:16, Philipp Stanner wrote: > > > struct drm_sched_init_args provides the possibility of letting the > > > scheduler use user-controlled workqueues, inst

Re: [PATCH] drm/sched: Discourage usage of separate workqueues

2025-06-04 Thread Simona Vetter
On Wed, Jun 04, 2025 at 11:41:25AM +0200, Christian König wrote: > On 6/4/25 10:16, Philipp Stanner wrote: > > struct drm_sched_init_args provides the possibility of letting the > > scheduler use user-controlled workqueues, instead of the scheduler > > creating its own workqueues. It's currently no

Re: [PATCH] drm/sched: Discourage usage of separate workqueues

2025-06-04 Thread Christian König
On 6/4/25 10:16, Philipp Stanner wrote: > struct drm_sched_init_args provides the possibility of letting the > scheduler use user-controlled workqueues, instead of the scheduler > creating its own workqueues. It's currently not documented who would > want to use that. > > Not sharing the submit_wq