Re: [PATCH] drm/radeon/evergreen_cs: fix int overflow errors in cs track offsets

2024-08-19 Thread Christian König
Am 05.08.24 um 09:34 schrieb Nikita Zhandarovich: On 7/30/24 23:56, Christian König wrote: Am 30.07.24 um 19:36 schrieb Nikita Zhandarovich: On 7/29/24 11:12, Christian König wrote: Am 29.07.24 um 20:04 schrieb Christian König: Am 29.07.24 um 19:26 schrieb Nikita Zhandarovich: Hi, On 7/29/

Re: [PATCH] drm/radeon/evergreen_cs: fix int overflow errors in cs track offsets

2024-08-05 Thread Alex Deucher
On Mon, Aug 5, 2024 at 3:34 AM Nikita Zhandarovich wrote: > > > > On 7/30/24 23:56, Christian König wrote: > > Am 30.07.24 um 19:36 schrieb Nikita Zhandarovich: > >> On 7/29/24 11:12, Christian König wrote: > >>> Am 29.07.24 um 20:04 schrieb Christian König: > Am 29.07.24 um 19:26 schrieb Nik

Re: [PATCH] drm/radeon/evergreen_cs: fix int overflow errors in cs track offsets

2024-08-05 Thread Nikita Zhandarovich
On 7/30/24 23:56, Christian König wrote: > Am 30.07.24 um 19:36 schrieb Nikita Zhandarovich: >> On 7/29/24 11:12, Christian König wrote: >>> Am 29.07.24 um 20:04 schrieb Christian König: Am 29.07.24 um 19:26 schrieb Nikita Zhandarovich: > Hi, > > On 7/29/24 02:23, Christian Köni

Re: [PATCH] drm/radeon/evergreen_cs: fix int overflow errors in cs track offsets

2024-07-30 Thread Christian König
Am 30.07.24 um 19:36 schrieb Nikita Zhandarovich: On 7/29/24 11:12, Christian König wrote: Am 29.07.24 um 20:04 schrieb Christian König: Am 29.07.24 um 19:26 schrieb Nikita Zhandarovich: Hi, On 7/29/24 02:23, Christian König wrote: Am 26.07.24 um 14:52 schrieb Alex Deucher: On Fri, Jul 26,

Re: [PATCH] drm/radeon/evergreen_cs: fix int overflow errors in cs track offsets

2024-07-30 Thread Nikita Zhandarovich
On 7/29/24 11:12, Christian König wrote: > Am 29.07.24 um 20:04 schrieb Christian König: >> Am 29.07.24 um 19:26 schrieb Nikita Zhandarovich: >>> Hi, >>> >>> On 7/29/24 02:23, Christian König wrote: Am 26.07.24 um 14:52 schrieb Alex Deucher: > On Fri, Jul 26, 2024 at 3:05 AM Christian K

Re: [PATCH] drm/radeon/evergreen_cs: fix int overflow errors in cs track offsets

2024-07-29 Thread Christian König
Am 29.07.24 um 20:04 schrieb Christian König: Am 29.07.24 um 19:26 schrieb Nikita Zhandarovich: Hi, On 7/29/24 02:23, Christian König wrote: Am 26.07.24 um 14:52 schrieb Alex Deucher: On Fri, Jul 26, 2024 at 3:05 AM Christian König wrote: Am 25.07.24 um 20:09 schrieb Nikita Zhandarovich: S

Re: [PATCH] drm/radeon/evergreen_cs: fix int overflow errors in cs track offsets

2024-07-29 Thread Christian König
Am 29.07.24 um 19:26 schrieb Nikita Zhandarovich: Hi, On 7/29/24 02:23, Christian König wrote: Am 26.07.24 um 14:52 schrieb Alex Deucher: On Fri, Jul 26, 2024 at 3:05 AM Christian König wrote: Am 25.07.24 um 20:09 schrieb Nikita Zhandarovich: Several cs track offsets (such as 'track->db_s_r

Re: [PATCH] drm/radeon/evergreen_cs: fix int overflow errors in cs track offsets

2024-07-29 Thread Nikita Zhandarovich
Hi, On 7/29/24 02:23, Christian König wrote: > Am 26.07.24 um 14:52 schrieb Alex Deucher: >> On Fri, Jul 26, 2024 at 3:05 AM Christian König >> wrote: >>> Am 25.07.24 um 20:09 schrieb Nikita Zhandarovich: Several cs track offsets (such as 'track->db_s_read_offset') either are initialize

Re: [PATCH] drm/radeon/evergreen_cs: fix int overflow errors in cs track offsets

2024-07-29 Thread Christian König
Am 26.07.24 um 14:52 schrieb Alex Deucher: On Fri, Jul 26, 2024 at 3:05 AM Christian König wrote: Am 25.07.24 um 20:09 schrieb Nikita Zhandarovich: Several cs track offsets (such as 'track->db_s_read_offset') either are initialized with or plainly take big enough values that, once shifted 8 bi

Re: [PATCH] drm/radeon/evergreen_cs: fix int overflow errors in cs track offsets

2024-07-26 Thread Alex Deucher
On Fri, Jul 26, 2024 at 3:05 AM Christian König wrote: > > Am 25.07.24 um 20:09 schrieb Nikita Zhandarovich: > > Several cs track offsets (such as 'track->db_s_read_offset') > > either are initialized with or plainly take big enough values that, > > once shifted 8 bits left, may be hit with intege

Re: [PATCH] drm/radeon/evergreen_cs: fix int overflow errors in cs track offsets

2024-07-26 Thread Christian König
I strongly suggest to revert that again. See my other mail. Christian. Am 25.07.24 um 22:59 schrieb Alex Deucher: Applied. Thanks! Alex On Thu, Jul 25, 2024 at 2:20 PM Nikita Zhandarovich wrote: Several cs track offsets (such as 'track->db_s_read_offset') either are initialized with or pla

Re: [PATCH] drm/radeon/evergreen_cs: fix int overflow errors in cs track offsets

2024-07-26 Thread Christian König
Am 25.07.24 um 20:09 schrieb Nikita Zhandarovich: Several cs track offsets (such as 'track->db_s_read_offset') either are initialized with or plainly take big enough values that, once shifted 8 bits left, may be hit with integer overflow if the resulting values end up going over u32 limit. Some

Re: [PATCH] drm/radeon/evergreen_cs: fix int overflow errors in cs track offsets

2024-07-25 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Jul 25, 2024 at 2:20 PM Nikita Zhandarovich wrote: > > Several cs track offsets (such as 'track->db_s_read_offset') > either are initialized with or plainly take big enough values that, > once shifted 8 bits left, may be hit with integer overflow if the > resulting