Re: [PATCH] drm/panthor: Lock XArray when getting entries for heap and VM

2024-11-06 Thread Liviu Dudau
On Wed, Nov 06, 2024 at 02:21:33PM +0100, Boris Brezillon wrote: > On Wed, 6 Nov 2024 13:10:37 + > Liviu Dudau wrote: > > > panthor_heap_pool_release() does not take the panthor_heap_pool::lock, so > > the protection > > is not really there. I could fix panthor_heap_pool_release() and then a

Re: [PATCH] drm/panthor: Lock XArray when getting entries for heap and VM

2024-11-06 Thread kernel test robot
Hi Liviu, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on linus/master v6.12-rc6 next-20241106] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '-

Re: [PATCH] drm/panthor: Lock XArray when getting entries for heap and VM

2024-11-06 Thread kernel test robot
Hi Liviu, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on linus/master v6.12-rc6 next-20241106] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '-

Re: [PATCH] drm/panthor: Lock XArray when getting entries for heap and VM

2024-11-06 Thread Boris Brezillon
On Wed, 6 Nov 2024 13:10:37 + Liviu Dudau wrote: > panthor_heap_pool_release() does not take the panthor_heap_pool::lock, so the > protection > is not really there. I could fix panthor_heap_pool_release() and then add a > lockdep_assert_held() before both calls to xa_load() if you think that

Re: [PATCH] drm/panthor: Lock XArray when getting entries for heap and VM

2024-11-06 Thread Steven Price
On 06/11/2024 12:07, Liviu Dudau wrote: > Similar to cac075706f29 ("drm/panthor: Fix race when converting > group handle to group object") we need to use the XArray's internal > locking when retrieving a pointer from there for heap and vm. > > Reported-by: Jann Horn > Cc: Boris Brezillon > Cc: S

Re: [PATCH] drm/panthor: Lock XArray when getting entries for heap and VM

2024-11-06 Thread Mihail Atanassov
Hi Liviu, On 06/11/2024 12:07, Liviu Dudau wrote: Similar to cac075706f29 ("drm/panthor: Fix race when converting group handle to group object") we need to use the XArray's internal locking when retrieving a pointer from there for heap and vm. Reported-by: Jann Horn Cc: Boris Brezillon Cc: St

Re: [PATCH] drm/panthor: Lock XArray when getting entries for heap and VM

2024-11-06 Thread Boris Brezillon
On Wed, 6 Nov 2024 13:17:29 + Steven Price wrote: > On 06/11/2024 12:07, Liviu Dudau wrote: > > Similar to cac075706f29 ("drm/panthor: Fix race when converting > > group handle to group object") we need to use the XArray's internal > > locking when retrieving a pointer from there for heap and

Re: [PATCH] drm/panthor: Lock XArray when getting entries for heap and VM

2024-11-06 Thread Steven Price
On 06/11/2024 13:34, Boris Brezillon wrote: > On Wed, 6 Nov 2024 13:17:29 + > Steven Price wrote: > >> On 06/11/2024 12:07, Liviu Dudau wrote: >>> Similar to cac075706f29 ("drm/panthor: Fix race when converting >>> group handle to group object") we need to use the XArray's internal >>> lockin

Re: [PATCH] drm/panthor: Lock XArray when getting entries for heap and VM

2024-11-06 Thread Mihail Atanassov
On 06/11/2024 12:14, Mihail Atanassov wrote: Hi Liviu, On 06/11/2024 12:07, Liviu Dudau wrote: Similar to cac075706f29 ("drm/panthor: Fix race when converting group handle to group object") we need to use the XArray's internal locking when retrieving a pointer from there for heap and vm. Repor

Re: [PATCH] drm/panthor: Lock XArray when getting entries for heap and VM

2024-11-06 Thread Liviu Dudau
On Wed, Nov 06, 2024 at 01:16:41PM +0100, Boris Brezillon wrote: > On Wed, 6 Nov 2024 12:07:48 + > Liviu Dudau wrote: > > > Similar to cac075706f29 ("drm/panthor: Fix race when converting > > group handle to group object") we need to use the XArray's internal > > locking when retrieving a po

Re: [PATCH] drm/panthor: Lock XArray when getting entries for heap and VM

2024-11-06 Thread Boris Brezillon
On Wed, 6 Nov 2024 12:07:48 + Liviu Dudau wrote: > Similar to cac075706f29 ("drm/panthor: Fix race when converting > group handle to group object") we need to use the XArray's internal > locking when retrieving a pointer from there for heap and vm. > > Reported-by: Jann Horn > Cc: Boris Br

Re: [PATCH] drm/panthor: Lock XArray when getting entries for heap and VM

2024-11-06 Thread Boris Brezillon
On Wed, 6 Nov 2024 12:07:48 + Liviu Dudau wrote: > Similar to cac075706f29 ("drm/panthor: Fix race when converting > group handle to group object") we need to use the XArray's internal > locking when retrieving a pointer from there for heap and vm. > > Reported-by: Jann Horn > Cc: Boris Br