Re: [PATCH] drm/nouveau/fbcon: fix oops without fbdev emulation

2017-10-18 Thread Pavel Roskin
Ben, David, I would hate if Linux 4.14 is released without this fix, as it would be a regression for my machine. As I mentioned, Linux 4.13 registers nouveaufb even without the dock, but Linux 4.14 doesn't. And that would cause an oops even if CONFIG_DRM_FBDEV_EMULATION is enabled. Please let me

Re: [PATCH] drm/nouveau/fbcon: fix oops without fbdev emulation

2017-10-17 Thread Ben Skeggs
On 10/18/2017 04:06 AM, Pavel Roskin wrote: > Ben, David, > > I would hate if Linux 4.14 is released without this fix, as it would > be a regression for my machine. As I mentioned, Linux 4.13 registers > nouveaufb even without the dock, but Linux 4.14 doesn't. And that > would cause an oops even i

Re: [PATCH] drm/nouveau/fbcon: fix oops without fbdev emulation

2017-09-27 Thread Daniel Vetter
On Tue, Sep 26, 2017 at 12:28:27PM -0700, Pavel Roskin wrote: > This is similar to an earlier commit 52dfcc5ccfbb ("drm/nouveau: fix for > disabled fbdev emulation"), but protects all other occurrences of > helper.fbdev in the source. > > I see an oops in nouveau_fbcon_accel_save_disable() called

Re: [PATCH] drm/nouveau/fbcon: fix oops without fbdev emulation

2017-09-27 Thread Pavel Roskin
Hi Daniel, I meant Linux 4.13 of course, sorry! Can you fix the description for me please? If not, I can resend the patch with the updated description. Let me add some context to my patch. My laptop is Dell Precision 7510 with dual graphics (Intel and Nvidia). The dock is connected to two monitor

Re: [PATCH] drm/nouveau/fbcon: fix oops without fbdev emulation

2017-09-26 Thread Daniel Vetter
On Sat, Sep 23, 2017 at 01:10:33PM -0700, Pavel Roskin wrote: > This is similar to an earlier commit 52dfcc5ccfbb ("drm/nouveau: fix for > disabled fbdev emulation"), but protects all occurrences of helper.fbdev > in the source. > > I see oops in nouveau_fbcon_accel_save_disable() called from > no