Re: [PATCH] drm/msm: Drop msm_read/writel

2024-04-11 Thread Dmitry Baryshkov
On Thu, Apr 11, 2024 at 08:27:22AM -0700, Bjorn Andersson wrote: > On Thu, Apr 11, 2024 at 04:31:41AM +0300, Dmitry Baryshkov wrote: > > On Wed, Apr 10, 2024 at 11:52:52PM +0200, Konrad Dybcio wrote: > [..] > > > diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.h > > > b/drivers/gpu/drm/msm/dsi/ph

Re: [PATCH] drm/msm: Drop msm_read/writel

2024-04-11 Thread Bjorn Andersson
On Thu, Apr 11, 2024 at 04:31:41AM +0300, Dmitry Baryshkov wrote: > On Wed, Apr 10, 2024 at 11:52:52PM +0200, Konrad Dybcio wrote: [..] > > diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.h > > b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.h > > index e4275d3ad581..5a5dc3faa971 100644 > > --- a/drivers/g

Re: [PATCH] drm/msm: Drop msm_read/writel

2024-04-10 Thread Dmitry Baryshkov
On Wed, Apr 10, 2024 at 11:52:52PM +0200, Konrad Dybcio wrote: > Totally useless. > > Signed-off-by: Konrad Dybcio > --- > only compile-tested > --- > drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 2 +- > drivers/gpu/drm/msm/adreno/a6xx_gmu.h | 12 ++-- > drivers/gpu/drm/msm/adren

Re: [PATCH] drm/msm: Drop msm_read/writel

2024-04-10 Thread Andrew Halaney
On Wed, Apr 10, 2024 at 11:52:52PM +0200, Konrad Dybcio wrote: > Totally useless. > > Signed-off-by: Konrad Dybcio A few more words in the description mentioning this just wraps readl/writel with no, but that's a minor nit and is easy to find when you finally see the removal in the end of the di