Re: [PATCH] drm/msm/dpu: Fix encoder CRC to account for CTM enablement

2023-11-21 Thread Abhinav Kumar
On 11/21/2023 4:27 PM, Rob Clark wrote: On Tue, Nov 21, 2023 at 4:41 PM Abhinav Kumar wrote: On 10/24/2023 12:01 PM, Abhinav Kumar wrote: On 10/23/2023 4:03 PM, Dmitry Baryshkov wrote: On Tue, 24 Oct 2023 at 01:36, Rob Clark wrote: On Mon, Oct 23, 2023 at 3:30 PM Dmitry Baryshkov

Re: [PATCH] drm/msm/dpu: Fix encoder CRC to account for CTM enablement

2023-11-21 Thread Rob Clark
On Tue, Nov 21, 2023 at 4:41 PM Abhinav Kumar wrote: > > > > On 10/24/2023 12:01 PM, Abhinav Kumar wrote: > > > > > > On 10/23/2023 4:03 PM, Dmitry Baryshkov wrote: > >> On Tue, 24 Oct 2023 at 01:36, Rob Clark wrote: > >>> > >>> On Mon, Oct 23, 2023 at 3:30 PM Dmitry Baryshkov > >>> wrote: > >>>

Re: [PATCH] drm/msm/dpu: Fix encoder CRC to account for CTM enablement

2023-11-21 Thread Abhinav Kumar
On 10/24/2023 12:01 PM, Abhinav Kumar wrote: On 10/23/2023 4:03 PM, Dmitry Baryshkov wrote: On Tue, 24 Oct 2023 at 01:36, Rob Clark wrote: On Mon, Oct 23, 2023 at 3:30 PM Dmitry Baryshkov wrote: On Tue, 24 Oct 2023 at 01:12, Rob Clark wrote: From: Rob Clark Seems like we need to

Re: [PATCH] drm/msm/dpu: Fix encoder CRC to account for CTM enablement

2023-10-24 Thread Abhinav Kumar
On 10/23/2023 4:03 PM, Dmitry Baryshkov wrote: On Tue, 24 Oct 2023 at 01:36, Rob Clark wrote: On Mon, Oct 23, 2023 at 3:30 PM Dmitry Baryshkov wrote: On Tue, 24 Oct 2023 at 01:12, Rob Clark wrote: From: Rob Clark Seems like we need to pick INPUT_SEL=1 when CTM is enabled. But not o

Re: [PATCH] drm/msm/dpu: Fix encoder CRC to account for CTM enablement

2023-10-23 Thread Dmitry Baryshkov
On Tue, 24 Oct 2023 at 01:36, Rob Clark wrote: > > On Mon, Oct 23, 2023 at 3:30 PM Dmitry Baryshkov > wrote: > > > > On Tue, 24 Oct 2023 at 01:12, Rob Clark wrote: > > > > > > From: Rob Clark > > > > > > Seems like we need to pick INPUT_SEL=1 when CTM is enabled. But not > > > otherwise. > > >

Re: [PATCH] drm/msm/dpu: Fix encoder CRC to account for CTM enablement

2023-10-23 Thread Rob Clark
On Mon, Oct 23, 2023 at 3:30 PM Dmitry Baryshkov wrote: > > On Tue, 24 Oct 2023 at 01:12, Rob Clark wrote: > > > > From: Rob Clark > > > > Seems like we need to pick INPUT_SEL=1 when CTM is enabled. But not > > otherwise. > > > > Suggested-by: Dmitry Baryshkov > > Signed-off-by: Rob Clark > >

Re: [PATCH] drm/msm/dpu: Fix encoder CRC to account for CTM enablement

2023-10-23 Thread Dmitry Baryshkov
On Tue, 24 Oct 2023 at 01:12, Rob Clark wrote: > > From: Rob Clark > > Seems like we need to pick INPUT_SEL=1 when CTM is enabled. But not > otherwise. > > Suggested-by: Dmitry Baryshkov > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 2 +- > drivers/gpu/drm/m