Re: [PATCH] drm/mediatek: Fix potential memory leak if vmap() fail

2023-07-06 Thread suijingfeng
Hi, On 2023/7/6 20:47, AngeloGioacchino Del Regno wrote: Il 26/06/23 20:58, Sui Jingfeng ha scritto: Also return -ENOMEM if such a failure happens, the implement should take responsibility for the error handling. Signed-off-by: Sui Jingfeng This commit needs a Fixes tag. Please add the rele

Re: [PATCH] drm/mediatek: Fix potential memory leak if vmap() fail

2023-07-06 Thread AngeloGioacchino Del Regno
Il 26/06/23 20:58, Sui Jingfeng ha scritto: Also return -ENOMEM if such a failure happens, the implement should take responsibility for the error handling. Signed-off-by: Sui Jingfeng This commit needs a Fixes tag. Please add the relevant one and resend. Thanks, Angelo --- drivers/gpu/dr

Re: [PATCH] drm/mediatek: Fix potential memory leak if vmap() fail

2023-07-06 Thread suijingfeng
Hi, thanks a lot! On 2023/7/6 20:13, Alexandre Mergnat wrote: On 26/06/2023 20:58, Sui Jingfeng wrote: Also return -ENOMEM if such a failure happens, the implement should take responsibility for the error handling. Reviewed-by: Alexandre Mergnat

Re: [PATCH] drm/mediatek: Fix potential memory leak if vmap() fail

2023-07-06 Thread suijingfeng
Hi, Thanks a lot! On 2023/7/6 19:39, Matthias Brugger wrote: On 26/06/2023 20:58, Sui Jingfeng wrote: Also return -ENOMEM if such a failure happens, the implement should take responsibility for the error handling. Signed-off-by: Sui Jingfeng ---   drivers/gpu/drm/mediatek/mtk_drm_gem.c | 6

Re: [PATCH] drm/mediatek: Fix potential memory leak if vmap() fail

2023-07-06 Thread Alexandre Mergnat
On 26/06/2023 20:58, Sui Jingfeng wrote: Also return -ENOMEM if such a failure happens, the implement should take responsibility for the error handling. Reviewed-by: Alexandre Mergnat -- Regards, Alexandre

Re: [PATCH] drm/mediatek: Fix potential memory leak if vmap() fail

2023-07-06 Thread Matthias Brugger
On 26/06/2023 20:58, Sui Jingfeng wrote: Also return -ENOMEM if such a failure happens, the implement should take responsibility for the error handling. Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/mediatek/mtk_drm_gem.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff