On Fri, March 11, 2011 08:26, Takashi Iwai wrote:
> At Fri, 11 Mar 2011 02:23:08 +0100 (CET),
> Indan Zupancic wrote:
>>
>> Hi,
>>
>> Some nitpicks below. I know you're just restoring the original code,
>> but if we improve it we can as well do it now.
>
> Well, Linus already merged my patch quickl
On Fri, 11 Mar 2011 02:23:08 +0100 (CET), "Indan Zupancic" wrote:
> Some nitpicks below. I know you're just restoring the original code,
> but if we improve it we can as well do it now.
Let's pend these changes until after 2.6.38; the backlight code is
fragile enough without trying to 'clean it
At Fri, 11 Mar 2011 02:23:08 +0100 (CET),
Indan Zupancic wrote:
>
> Hi,
>
> Some nitpicks below. I know you're just restoring the original code,
> but if we improve it we can as well do it now.
Well, Linus already merged my patch quickly. So, we can improve the
readability as an additional patc
On Thu, March 10, 2011 20:36, Keith Packard wrote:
> On Thu, 10 Mar 2011 14:02:12 +0100, Takashi Iwai wrote:
>> +val &= ~1;
>
> The reason for this is that some ancient platforms wire this bit to
> be "go to max backlight", or at least that's why this was in the 2D
> driver fro
On Thu, Mar 10, 2011 at 5:23 PM, Indan Zupancic wrote:
>
> After this patch, combined with my new patch
>
> "drm/i915: Fix DPMS and suspend interaction for intel_panel.c"
>
> all known backlight problems should be fixed.
Btw, can you repost that one as a new email (and cc keithp too)? I
think it
Hi,
Some nitpicks below. I know you're just restoring the original code,
but if we improve it we can as well do it now.
On Thu, March 10, 2011 14:02, Takashi Iwai wrote:
> This reverts commit 951f3512dba5bd44cda3e5ee22b4b522e4bb09fb
>
> drm/i915: Do not handle backlight combination mode speci
On Thu, 10 Mar 2011 14:02:12 +0100, Takashi Iwai wrote:
> This reverts commit 951f3512dba5bd44cda3e5ee22b4b522e4bb09fb
>
> drm/i915: Do not handle backlight combination mode specially
>
> since this commit introduced other regressions due to untouched LBPC
> register, e.g. the backlight dimm
