Re: [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

2023-01-30 Thread Andi Shyti
Hi Rodrigo, > > > In the call flow invoked by intel_pcode_init(), I've added brief comments > > > where further clarification is needed in this scenario, and a description > > > of > > > the suspicious scenario at the bottom. > > > > > > --

Re: [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

2023-01-30 Thread Rodrigo Vivi
On Mon, Jan 30, 2023 at 09:48:31AM +0100, Andi Shyti wrote: > Hi GG, > > thanks for the deep analysis! > > > Hi Andi, > > In the call flow invoked by intel_pcode_init(), I've added brief comments > > where further clarification is needed in this scenario, and a description of > > the suspicious s

Re: [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

2023-01-30 Thread Andi Shyti
Hi GG, thanks for the deep analysis! > Hi Andi, > In the call flow invoked by intel_pcode_init(), I've added brief comments > where further clarification is needed in this scenario, and a description of > the suspicious scenario at the bottom. > >

Re: [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

2023-01-27 Thread Gwan-gyeong Mun
On 1/27/23 11:00 AM, Andi Shyti wrote: Hi Gwan-gyeong, thanks for the review and the thorough explanation. On Fri, Jan 27, 2023 at 08:50:26AM +0200, Gwan-gyeong Mun wrote: On 1/11/23 5:36 PM, Andi Shyti wrote: On Wed, Jan 11, 2023 at 03:18:38PM +0200, Jani Nikula wrote: On Wed, 11 Jan 2

Re: [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

2023-01-27 Thread Andi Shyti
Hi Gwan-gyeong, thanks for the review and the thorough explanation. On Fri, Jan 27, 2023 at 08:50:26AM +0200, Gwan-gyeong Mun wrote: > > > On 1/11/23 5:36 PM, Andi Shyti wrote: > > On Wed, Jan 11, 2023 at 03:18:38PM +0200, Jani Nikula wrote: > > > On Wed, 11 Jan 2023, Andi Shyti wrote: > > > >

Re: [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

2023-01-26 Thread Gwan-gyeong Mun
On 1/11/23 5:36 PM, Andi Shyti wrote: On Wed, Jan 11, 2023 at 03:18:38PM +0200, Jani Nikula wrote: On Wed, 11 Jan 2023, Andi Shyti wrote: From: Aravind Iddamsetty During module load not all the punit transaction have completed and we might end up timing out, as shown by the following warn

Re: [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

2023-01-11 Thread Jani Nikula
On Wed, 11 Jan 2023, Andi Shyti wrote: > On Wed, Jan 11, 2023 at 03:18:38PM +0200, Jani Nikula wrote: >> On Wed, 11 Jan 2023, Andi Shyti wrote: >> > From: Aravind Iddamsetty >> > >> > During module load not all the punit transaction have completed >> > and we might end up timing out, as shown by

Re: [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

2023-01-11 Thread Andi Shyti
Hi Rodrigo, On Wed, Jan 11, 2023 at 10:25:56AM -0500, Rodrigo Vivi wrote: > On Wed, Jan 11, 2023 at 11:44:47AM +0100, Andi Shyti wrote: > > From: Aravind Iddamsetty > > > > During module load not all the punit transaction have completed > > and we might end up timing out, as shown by the followi

Re: [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

2023-01-11 Thread Andi Shyti
On Wed, Jan 11, 2023 at 03:18:38PM +0200, Jani Nikula wrote: > On Wed, 11 Jan 2023, Andi Shyti wrote: > > From: Aravind Iddamsetty > > > > During module load not all the punit transaction have completed > > and we might end up timing out, as shown by the following > > warning: > > Root cause? >

Re: [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

2023-01-11 Thread Rodrigo Vivi
On Wed, Jan 11, 2023 at 11:44:47AM +0100, Andi Shyti wrote: > From: Aravind Iddamsetty > > During module load not all the punit transaction have completed > and we might end up timing out, as shown by the following > warning: > >i915 :4d:00.0: drm_WARN_ON_ONCE(timeout_base_ms > 3) > > W

Re: [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

2023-01-11 Thread Jani Nikula
On Wed, 11 Jan 2023, Andi Shyti wrote: > From: Aravind Iddamsetty > > During module load not all the punit transaction have completed > and we might end up timing out, as shown by the following > warning: Root cause? > >i915 :4d:00.0: drm_WARN_ON_ONCE(timeout_base_ms > 3) > > Wait 10 se