Re: [PATCH] drm/i915/gem: Make i915_gem_shrinker multi-gt aware

2023-09-25 Thread Andi Shyti
Hi Jani, > >>struct i915_vma *vma, *next; > >>unsigned long freed_pages = 0; > >>intel_wakeref_t wakeref; > >> + struct intel_gt *gt; > >> + int i; > > > > the trend is to use 'unsigned int' here and I've seen it > > reviewed. Personally, if I really have to express a preference, I >

Re: [PATCH] drm/i915/gem: Make i915_gem_shrinker multi-gt aware

2023-09-25 Thread Jani Nikula
On Mon, 25 Sep 2023, Andi Shyti wrote: > Hi Nirmoy, > > you forgot the v2 here. > > On Mon, Sep 25, 2023 at 03:49:38PM +0200, Nirmoy Das wrote: >> From: Jonathan Cavitt >> >> Where applicable, use for_each_gt instead of to_gt in the >> i915_gem_shrinker functions to make them apply to more than

Re: [PATCH] drm/i915/gem: Make i915_gem_shrinker multi-gt aware

2023-09-25 Thread Andi Shyti
Hi Nirmoy, you forgot the v2 here. On Mon, Sep 25, 2023 at 03:49:38PM +0200, Nirmoy Das wrote: > From: Jonathan Cavitt > > Where applicable, use for_each_gt instead of to_gt in the > i915_gem_shrinker functions to make them apply to more than just the > primary GT. Specifically, this ensure i9