Re: [PATCH] drm/bridge: fix stack usage warning on old gcc

2020-04-29 Thread Sam Ravnborg
Hi Arnd. On Tue, Apr 28, 2020 at 11:53:54PM +0200, Arnd Bergmann wrote: > Some older versions of gcc badly optimize code that passes > an inline function argument into another function by reference, > causing huge stack usage: > > drivers/gpu/drm/bridge/tc358768.c: In function 'tc358768_bridge_pr

Re: [PATCH] drm/bridge: fix stack usage warning on old gcc

2020-04-29 Thread Tomi Valkeinen
On 29/04/2020 11:02, Arnd Bergmann wrote: On Wed, Apr 29, 2020 at 9:56 AM Tomi Valkeinen wrote: diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c index 1b39e8d37834..6650fe4cfc20 100644 --- a/drivers/gpu/drm/bridge/tc358768.c +++ b/drivers/gpu/drm/bridge/tc3587

Re: [PATCH] drm/bridge: fix stack usage warning on old gcc

2020-04-29 Thread Tomi Valkeinen
On 29/04/2020 00:53, Arnd Bergmann wrote: Some older versions of gcc badly optimize code that passes an inline function argument into another function by reference, causing huge stack usage: drivers/gpu/drm/bridge/tc358768.c: In function 'tc358768_bridge_pre_enable': drivers/gpu/drm/bridge/tc358

Re: [PATCH] drm/bridge: fix stack usage warning on old gcc

2020-04-29 Thread Arnd Bergmann
On Wed, Apr 29, 2020 at 9:56 AM Tomi Valkeinen wrote: > > diff --git a/drivers/gpu/drm/bridge/tc358768.c > > b/drivers/gpu/drm/bridge/tc358768.c > > index 1b39e8d37834..6650fe4cfc20 100644 > > --- a/drivers/gpu/drm/bridge/tc358768.c > > +++ b/drivers/gpu/drm/bridge/tc358768.c > > @@ -178,6 +178,8