Re: [PATCH] drm/amdkfd: Integer overflows in ioctl

2018-05-11 Thread Oded Gabbay
On Tue, Apr 24, 2018 at 9:58 PM, Felix Kuehling wrote: > Reviewed-by: Felix Kuehling > > We could probably add a sanity check for n_devices to avoid user mode > causing excessive memory allocations in the kernel. There is no good > reason for this to be bigger than the number of GPUs in the syste

Re: [PATCH] drm/amdkfd: Integer overflows in ioctl

2018-04-25 Thread Felix Kuehling
On 2018-04-25 05:21 AM, Dan Carpenter wrote: > On Tue, Apr 24, 2018 at 02:58:10PM -0400, Felix Kuehling wrote: >> Reviewed-by: Felix Kuehling >> >> We could probably add a sanity check for n_devices to avoid user mode >> causing excessive memory allocations in the kernel. There is no good >> reaso

Re: [PATCH] drm/amdkfd: Integer overflows in ioctl

2018-04-25 Thread Dan Carpenter
On Tue, Apr 24, 2018 at 02:58:10PM -0400, Felix Kuehling wrote: > Reviewed-by: Felix Kuehling > > We could probably add a sanity check for n_devices to avoid user mode > causing excessive memory allocations in the kernel. There is no good > reason for this to be bigger than the number of GPUs in

Re: [PATCH] drm/amdkfd: Integer overflows in ioctl

2018-04-24 Thread Felix Kuehling
Reviewed-by: Felix Kuehling We could probably add a sanity check for n_devices to avoid user mode causing excessive memory allocations in the kernel. There is no good reason for this to be bigger than the number of GPUs in the system. The maximum number of GPUs supported due to device minor limit