Re: [PATCH] drm/amdgpu: Fix memory leak in amdgpu_cs_pass1

2022-11-11 Thread Christian König
Am 10.11.22 um 15:33 schrieb Dong Chenchen: When p->gang_size equals 0, amdgpu_cs_pass1() will return directly without freeing chunk_array, which will cause a memory leak issue, this patch fixes it. Fixes: 4624459c84d7 ("drm/amdgpu: add gang submit frontend v6") Signed-off-by: Dong Chenchen G

Re: [PATCH] drm/amdgpu: Fix memory leak in amdgpu_cs_pass1

2022-11-10 Thread Alex Deucher
On Thu, Nov 10, 2022 at 1:08 PM Luben Tuikov wrote: > > Thanks for fixing this. > > Please add a Cc tag to stable, and repost. No need for stable. This patch just went upstream in 6.1, so I can include it in my 6.1 fixes pull next week. Applied. Thanks! Alex > > Reviewed-by: Luben Tuikov >

Re: [PATCH] drm/amdgpu: Fix memory leak in amdgpu_cs_pass1

2022-11-10 Thread Luben Tuikov
Thanks for fixing this. Please add a Cc tag to stable, and repost. Reviewed-by: Luben Tuikov Regards, Luben On 2022-11-10 09:33, Dong Chenchen wrote: > When p->gang_size equals 0, amdgpu_cs_pass1() will return directly > without freeing chunk_array, which will cause a memory leak issue, > this

Re: [PATCH] drm/amdgpu: Fix memory leak in hpd_rx_irq_create_workqueue()

2022-09-13 Thread Alex Deucher
Applied. Thanks! On Mon, Sep 12, 2022 at 10:12 PM Rafael Mendonca wrote: > > If construction of the array of work queues to handle hpd_rx_irq offload > work fails, we need to unwind. Destroy all the created workqueues and > the allocated memory for the hpd_rx_irq_offload_work_queue struct array.

Re: [PATCH] drm/amdgpu: Fix memory leak in amdgpu_fence_emit

2019-10-21 Thread Koenig, Christian
Am 21.10.19 um 20:09 schrieb Navid Emamdoost: > In the impelementation of amdgpu_fence_emit() if dma_fence_wait() fails > and returns an errno, before returning the allocated memory for fence > should be released. > > Fixes: 3d2aca8c8620 ("drm/amdgpu: fix old fence check in amdgpu_fence_emit") > Si

Re: [PATCH] drm/amdgpu: fix memory leak

2019-10-04 Thread Nirmoy
On 10/4/19 1:30 PM, Koenig, Christian wrote: > Am 04.10.19 um 13:26 schrieb Das, Nirmoy: >> On 10/4/19 1:13 PM, Koenig, Christian wrote: > NAK, that is a double free. The bo list entries are freed by > amdgpu_bo_list_put(). Thanks, didn't realize that. >>> Wait a second, what entries

Re: [PATCH] drm/amdgpu: fix memory leak

2019-10-04 Thread Koenig, Christian
Am 04.10.19 um 13:26 schrieb Das, Nirmoy: > On 10/4/19 1:13 PM, Koenig, Christian wrote: NAK, that is a double free. The bo list entries are freed by amdgpu_bo_list_put(). >>> Thanks, didn't realize that. >> Wait a second, what entries are you talking about? >> >> The entries in the list

Re: [PATCH] drm/amdgpu: fix memory leak

2019-10-04 Thread Nirmoy
On 10/4/19 1:13 PM, Koenig, Christian wrote: > >>> NAK, that is a double free. The bo list entries are freed by >>> amdgpu_bo_list_put(). >> Thanks, didn't realize that. > Wait a second, what entries are you talking about? > > The entries in the list object are freed when amdgpu_bo_list_put() is >

Re: [PATCH] drm/amdgpu: fix memory leak

2019-10-04 Thread Koenig, Christian
Am 04.10.19 um 13:00 schrieb Das, Nirmoy: > On 10/4/19 12:44 PM, Koenig, Christian wrote: >> First of all please send mails regarding amdgpu to the amd-gfx mailing >> list and not lkml/dri-devel. > Okay. >> Am 04.10.19 um 12:17 schrieb Nirmoy Das: >>> In amdgpu_bo_list_ioctl when idr_alloc fails >>

Re: [PATCH] drm/amdgpu: fix memory leak

2019-10-04 Thread Nirmoy
On 10/4/19 12:44 PM, Koenig, Christian wrote: > First of all please send mails regarding amdgpu to the amd-gfx mailing > list and not lkml/dri-devel. Okay. > Am 04.10.19 um 12:17 schrieb Nirmoy Das: >> In amdgpu_bo_list_ioctl when idr_alloc fails >> don't return without freeing bo list entry. >> >

Re: [PATCH] drm/amdgpu: fix memory leak

2019-10-04 Thread Koenig, Christian
First of all please send mails regarding amdgpu to the amd-gfx mailing list and not lkml/dri-devel. Am 04.10.19 um 12:17 schrieb Nirmoy Das: > In amdgpu_bo_list_ioctl when idr_alloc fails > don't return without freeing bo list entry. > > Fixes: 964d0fbf6301d ("drm/amdgpu: Allow to create BO lists