Christian König, Simon Ser In fact, the code looks strange, we return
the return code, but for some reason we also write false and 0. In my
opinion, the caller should do this.
Of course, you are right, but I look from the position that nothing
should fall in the user system. There may be strange er
Am 08.04.22 um 15:21 schrieb Grigory Vasilyev:
Simon Ser and Bas Nieuwenhuizen, do you understand that you are
proposing to make the code less safe in the future? In the future,
someone might rewrite the code and we'll get an error.
Which is perfectly fine.
See error handling is to handle user
On Friday, April 8th, 2022 at 15:21, Grigory Vasilyev wrote:
> Simon Ser and Bas Nieuwenhuizen, do you understand that you are
> proposing to make the code less safe in the future? In the future,
> someone might rewrite the code and we'll get an error.
I don't think we should blindly add NULL ch
Simon Ser and Bas Nieuwenhuizen, do you understand that you are
proposing to make the code less safe in the future? In the future,
someone might rewrite the code and we'll get an error.
пт, 8 апр. 2022 г. в 14:48, Simon Ser :
>
> On Friday, April 8th, 2022 at 13:28, Bas Nieuwenhuizen
> wrote:
>
On Friday, April 8th, 2022 at 13:28, Bas Nieuwenhuizen
wrote:
> On Fri, Apr 8, 2022 at 12:01 PM Simon Ser cont...@emersion.fr wrote:
>
> > Is amdgpu_display_get_fb_info ever called with NULL
> > tiling_flags/tmz_surface?
> > If not, there's no point in adding NULL checks.
>
> It isn't called wi
On Fri, Apr 8, 2022 at 12:01 PM Simon Ser wrote:
>
> Is amdgpu_display_get_fb_info ever called with NULL tiling_flags/tmz_surface?
> If not, there's no point in adding NULL checks.
It isn't called with NULL anywhere, the NULL checks that already exist
seem redundant.
Is amdgpu_display_get_fb_info ever called with NULL tiling_flags/tmz_surface?
If not, there's no point in adding NULL checks.
