Re: [PATCH] drm/amd/display: Fix boolean expression in get_surf_rq_param

2019-03-21 Thread Gustavo A. R. Silva
Hi Harry, I noticed this patch is already in mainline, but the stable tag was removed. What is the reason for that if this bug is present in stable? Thanks -- Gustavo On 1/3/19 3:11 PM, Wentland, Harry wrote: > On 2019-01-03 2:48 p.m., Gustavo A. R. Silva wrote: >> Fix boolean expression by usi

Re: [PATCH] drm/amd/display: Fix boolean expression in get_surf_rq_param

2019-03-21 Thread Gustavo A. R. Silva
On 3/21/19 10:14 PM, Joe Perches wrote: > On Thu, 2019-03-21 at 22:10 -0500, Gustavo A. R. Silva wrote: >> Hi Harry, >> >> I noticed this patch is already in mainline, but the stable tag >> was removed. What is the reason for that if this bug is present >> in stable? > > It's not a bug, it's ju

Re: [PATCH] drm/amd/display: Fix boolean expression in get_surf_rq_param

2019-03-21 Thread Joe Perches
On Thu, 2019-03-21 at 22:10 -0500, Gustavo A. R. Silva wrote: > Hi Harry, > > I noticed this patch is already in mainline, but the stable tag > was removed. What is the reason for that if this bug is present > in stable? It's not a bug, it's just a style issue and the && use in some compilers it

Re: [PATCH] drm/amd/display: Fix boolean expression in get_surf_rq_param

2019-01-04 Thread Gustavo A. R. Silva
On 1/3/19 3:11 PM, Wentland, Harry wrote: On 2019-01-03 2:48 p.m., Gustavo A. R. Silva wrote: Fix boolean expression by using logical AND operator '&&' instead of bitwise operator '&'. This issue was detected with the help of Coccinelle. Fixes: 6d04ee9dc101 ("drm/amd/display: Restructuring a

Re: [PATCH] drm/amd/display: Fix boolean expression in get_surf_rq_param

2019-01-03 Thread Wentland, Harry
On 2019-01-03 2:48 p.m., Gustavo A. R. Silva wrote: > Fix boolean expression by using logical AND operator '&&' > instead of bitwise operator '&'. > > This issue was detected with the help of Coccinelle. > > Fixes: 6d04ee9dc101 ("drm/amd/display: Restructuring and cleaning up DML") > Cc: sta...@v