Re: [PATCH] dmabuf: Add the capability to expose DMA-BUF stats in sysfs

2020-12-14 Thread Hridya Valsaraju
Thank you Christian! On Fri, Dec 11, 2020 at 12:03 AM Christian König wrote: > > Am 10.12.20 um 23:41 schrieb Hridya Valsaraju: > > Thanks again for the reviews! > > > > On Thu, Dec 10, 2020 at 3:03 AM Christian König > > wrote: > >> Am 10.12.20 um 11:56 schrieb Greg KH: > >>> On Thu, Dec 10, 20

Re: [PATCH] dmabuf: Add the capability to expose DMA-BUF stats in sysfs

2020-12-11 Thread John Stultz
On Thu, Dec 10, 2020 at 5:10 AM Daniel Vetter wrote: > On Thu, Dec 10, 2020 at 1:06 PM Greg KH wrote: > > On Thu, Dec 10, 2020 at 12:26:01PM +0100, Daniel Vetter wrote: > > > On Thu, Dec 10, 2020 at 11:55 AM Greg KH > > > wrote: > > > > On Thu, Dec 10, 2020 at 11:27:27AM +0100, Daniel Vetter wr

Re: [PATCH] dmabuf: Add the capability to expose DMA-BUF stats in sysfs

2020-12-11 Thread Hridya Valsaraju
Thank you for the reviews Greg, Christian and Daniel! On Thu, Dec 10, 2020 at 1:59 AM Christian König wrote: > > In general a good idea, but I have a few concern/comments here. > > Am 10.12.20 um 05:43 schrieb Hridya Valsaraju: > > This patch allows statistics to be enabled for each DMA-BUF in >

Re: [PATCH] dmabuf: Add the capability to expose DMA-BUF stats in sysfs

2020-12-11 Thread Hridya Valsaraju
Thanks again for the reviews! On Thu, Dec 10, 2020 at 3:03 AM Christian König wrote: > > Am 10.12.20 um 11:56 schrieb Greg KH: > > On Thu, Dec 10, 2020 at 11:27:27AM +0100, Daniel Vetter wrote: > >> On Thu, Dec 10, 2020 at 11:10:45AM +0100, Greg KH wrote: > >>> On Thu, Dec 10, 2020 at 10:58:50AM

Re: [PATCH] dmabuf: Add the capability to expose DMA-BUF stats in sysfs

2020-12-11 Thread Christian König
Am 10.12.20 um 23:41 schrieb Hridya Valsaraju: Thanks again for the reviews! On Thu, Dec 10, 2020 at 3:03 AM Christian König wrote: Am 10.12.20 um 11:56 schrieb Greg KH: On Thu, Dec 10, 2020 at 11:27:27AM +0100, Daniel Vetter wrote: On Thu, Dec 10, 2020 at 11:10:45AM +0100, Greg KH wrote: O

Re: [PATCH] dmabuf: Add the capability to expose DMA-BUF stats in sysfs

2020-12-10 Thread Daniel Vetter
On Thu, Dec 10, 2020 at 1:06 PM Greg KH wrote: > > On Thu, Dec 10, 2020 at 12:26:01PM +0100, Daniel Vetter wrote: > > On Thu, Dec 10, 2020 at 11:55 AM Greg KH wrote: > > > > > > On Thu, Dec 10, 2020 at 11:27:27AM +0100, Daniel Vetter wrote: > > > > On Thu, Dec 10, 2020 at 11:10:45AM +0100, Greg K

Re: [PATCH] dmabuf: Add the capability to expose DMA-BUF stats in sysfs

2020-12-10 Thread Greg KH
On Thu, Dec 10, 2020 at 12:26:01PM +0100, Daniel Vetter wrote: > On Thu, Dec 10, 2020 at 11:55 AM Greg KH wrote: > > > > On Thu, Dec 10, 2020 at 11:27:27AM +0100, Daniel Vetter wrote: > > > On Thu, Dec 10, 2020 at 11:10:45AM +0100, Greg KH wrote: > > > > On Thu, Dec 10, 2020 at 10:58:50AM +0100, C

Re: [PATCH] dmabuf: Add the capability to expose DMA-BUF stats in sysfs

2020-12-10 Thread Daniel Vetter
On Thu, Dec 10, 2020 at 11:55 AM Greg KH wrote: > > On Thu, Dec 10, 2020 at 11:27:27AM +0100, Daniel Vetter wrote: > > On Thu, Dec 10, 2020 at 11:10:45AM +0100, Greg KH wrote: > > > On Thu, Dec 10, 2020 at 10:58:50AM +0100, Christian König wrote: > > > > In general a good idea, but I have a few co

Re: [PATCH] dmabuf: Add the capability to expose DMA-BUF stats in sysfs

2020-12-10 Thread Christian König
Am 10.12.20 um 11:56 schrieb Greg KH: On Thu, Dec 10, 2020 at 11:27:27AM +0100, Daniel Vetter wrote: On Thu, Dec 10, 2020 at 11:10:45AM +0100, Greg KH wrote: On Thu, Dec 10, 2020 at 10:58:50AM +0100, Christian König wrote: In general a good idea, but I have a few concern/comments here. Am 10.

Re: [PATCH] dmabuf: Add the capability to expose DMA-BUF stats in sysfs

2020-12-10 Thread Greg KH
On Thu, Dec 10, 2020 at 11:27:27AM +0100, Daniel Vetter wrote: > On Thu, Dec 10, 2020 at 11:10:45AM +0100, Greg KH wrote: > > On Thu, Dec 10, 2020 at 10:58:50AM +0100, Christian König wrote: > > > In general a good idea, but I have a few concern/comments here. > > > > > > Am 10.12.20 um 05:43 schr

Re: [PATCH] dmabuf: Add the capability to expose DMA-BUF stats in sysfs

2020-12-10 Thread Daniel Vetter
On Thu, Dec 10, 2020 at 11:10:45AM +0100, Greg KH wrote: > On Thu, Dec 10, 2020 at 10:58:50AM +0100, Christian König wrote: > > In general a good idea, but I have a few concern/comments here. > > > > Am 10.12.20 um 05:43 schrieb Hridya Valsaraju: > > > This patch allows statistics to be enabled fo

Re: [PATCH] dmabuf: Add the capability to expose DMA-BUF stats in sysfs

2020-12-10 Thread Greg KH
On Thu, Dec 10, 2020 at 10:58:50AM +0100, Christian König wrote: > In general a good idea, but I have a few concern/comments here. > > Am 10.12.20 um 05:43 schrieb Hridya Valsaraju: > > This patch allows statistics to be enabled for each DMA-BUF in > > sysfs by enabling the config CONFIG_DMABUF_SY

Re: [PATCH] dmabuf: Add the capability to expose DMA-BUF stats in sysfs

2020-12-10 Thread Christian König
In general a good idea, but I have a few concern/comments here. Am 10.12.20 um 05:43 schrieb Hridya Valsaraju: This patch allows statistics to be enabled for each DMA-BUF in sysfs by enabling the config CONFIG_DMABUF_SYSFS_STATS. The following stats will be exposed by the interface: /sys/kerne

Re: [PATCH] dmabuf: Add the capability to expose DMA-BUF stats in sysfs

2020-12-10 Thread Greg KH
On Wed, Dec 09, 2020 at 08:43:57PM -0800, Hridya Valsaraju wrote: > This patch allows statistics to be enabled for each DMA-BUF in > sysfs by enabling the config CONFIG_DMABUF_SYSFS_STATS. > > The following stats will be exposed by the interface: > > /sys/kernel/dmabuf//exporter_name > /sys/kerne