Re: [PATCH] dma-buf: Add debugfs support

2012-12-19 Thread Dave Airlie
On Thu, Dec 20, 2012 at 11:26 AM, Dave Airlie wrote: > On Fri, Dec 14, 2012 at 7:36 PM, wrote: >> From: Sumit Semwal >> >> Add debugfs support to make it easier to print debug information >> about the dma-buf buffers. >> I've attached two patches that make it work on my system, and fix the war

Re: [PATCH] dma-buf: Add debugfs support

2012-12-19 Thread Dave Airlie
On Fri, Dec 14, 2012 at 7:36 PM, wrote: > From: Sumit Semwal > > Add debugfs support to make it easier to print debug information > about the dma-buf buffers. > I like thie idea, /home/airlied/devel/kernel/drm-2.6/drivers/base/dma-buf.c: In function ‘dma_buf_describe’: /home/airlied/devel/kern

Re: [PATCH] dma-buf: Add debugfs support

2012-12-17 Thread Sumit Semwal
On 14 December 2012 16:04, Daniel Vetter wrote: > > Missed one ... > > On Fri, Dec 14, 2012 at 10:36 AM, wrote: > > + list_for_each_entry(attach_obj, &buf_obj->attachments, > > node) { > > + seq_printf(s, "\t\t"); > > + > > + seq_printf(

Re: [PATCH] dma-buf: Add debugfs support

2012-12-14 Thread Daniel Vetter
Missed one ... On Fri, Dec 14, 2012 at 10:36 AM, wrote: > + list_for_each_entry(attach_obj, &buf_obj->attachments, node) { > + seq_printf(s, "\t\t"); > + > + seq_printf(s, "%s\n", attach_obj->dev->init_name); > + att

Re: [PATCH] dma-buf: Add debugfs support

2012-12-14 Thread Daniel Vetter
On Fri, Dec 14, 2012 at 10:36 AM, wrote: > From: Sumit Semwal > > Add debugfs support to make it easier to print debug information > about the dma-buf buffers. > > Signed-off-by: Sumit Semwal Looks line, only nitpick is that we have no idea who exported a given buffer. So what about adding a n