Re: [PATCH] component: Move host device to end of device lists on binding

2021-05-13 Thread Russell King - ARM Linux admin
On Mon, May 10, 2021 at 06:05:21PM +0200, Daniel Vetter wrote: > Entirely aside, but an s/master/aggregate/ or similar over the entire > component.c codebase would help a pile in making it easier to understand > which part does what. Or at least I'm always terribly confused about which > bind binds

Re: [PATCH] component: Move host device to end of device lists on binding

2021-05-11 Thread Daniel Vetter
On Tue, May 11, 2021 at 10:19:09AM -0700, Stephen Boyd wrote: > Quoting Daniel Vetter (2021-05-11 06:39:36) > > On Tue, May 11, 2021 at 12:52 PM Rafael J. Wysocki > > wrote: > > > > > > On Mon, May 10, 2021 at 9:08 PM Stephen Boyd wrote: > > > > > > [cut] > > > > > > > > > > > > > > > > > > I wi

Re: [PATCH] component: Move host device to end of device lists on binding

2021-05-11 Thread Stephen Boyd
Quoting Russell King - ARM Linux admin (2021-05-11 07:42:37) > On Sat, May 08, 2021 at 12:41:18AM -0700, Stephen Boyd wrote: > > Within the component device framework this usually isn't that bad > > because the real driver work is done at bind time via > > component{,master}_ops::bind(). It becomes

Re: [PATCH] component: Move host device to end of device lists on binding

2021-05-11 Thread Rafael J. Wysocki
On Tue, May 11, 2021 at 7:00 PM Stephen Boyd wrote: > > Quoting Rafael J. Wysocki (2021-05-11 03:52:06) > > On Mon, May 10, 2021 at 9:08 PM Stephen Boyd wrote: > > > > [cut] > > > > > > > > > > > > > > I will try it, but then I wonder about things like system wide > > > > > suspend/resume too. Th

Re: [PATCH] component: Move host device to end of device lists on binding

2021-05-11 Thread Stephen Boyd
Quoting Daniel Vetter (2021-05-11 06:39:36) > On Tue, May 11, 2021 at 12:52 PM Rafael J. Wysocki wrote: > > > > On Mon, May 10, 2021 at 9:08 PM Stephen Boyd wrote: > > > > [cut] > > > > > > > > > > > > > > I will try it, but then I wonder about things like system wide > > > > > suspend/resume too

Re: [PATCH] component: Move host device to end of device lists on binding

2021-05-11 Thread Stephen Boyd
Quoting Rafael J. Wysocki (2021-05-11 03:52:06) > On Mon, May 10, 2021 at 9:08 PM Stephen Boyd wrote: > > [cut] > > > > > > > > > > I will try it, but then I wonder about things like system wide > > > > suspend/resume too. The drm encoder chain would need to reimplement the > > > > logic for syste

Re: [PATCH] component: Move host device to end of device lists on binding

2021-05-11 Thread Russell King - ARM Linux admin
On Sat, May 08, 2021 at 12:41:18AM -0700, Stephen Boyd wrote: > Within the component device framework this usually isn't that bad > because the real driver work is done at bind time via > component{,master}_ops::bind(). It becomes a problem when the driver > core, or host driver, wants to operate o

Re: [PATCH] component: Move host device to end of device lists on binding

2021-05-11 Thread Daniel Vetter
On Tue, May 11, 2021 at 12:52 PM Rafael J. Wysocki wrote: > > On Mon, May 10, 2021 at 9:08 PM Stephen Boyd wrote: > > [cut] > > > > > > > > > > I will try it, but then I wonder about things like system wide > > > > suspend/resume too. The drm encoder chain would need to reimplement the > > > > lo

Re: [PATCH] component: Move host device to end of device lists on binding

2021-05-11 Thread Rafael J. Wysocki
On Mon, May 10, 2021 at 9:08 PM Stephen Boyd wrote: [cut] > > > > > > I will try it, but then I wonder about things like system wide > > > suspend/resume too. The drm encoder chain would need to reimplement the > > > logic for system wide suspend/resume so that any PM ops attached to the > > > m

Re: [PATCH] component: Move host device to end of device lists on binding

2021-05-10 Thread Stephen Boyd
Quoting Daniel Vetter (2021-05-10 11:26:40) > On Mon, May 10, 2021 at 7:52 PM Stephen Boyd wrote: > > The device list now has msm, i2c, bridge in that order. When we go to > > system wide shutdown the bridge is shutdown first, then the i2c bus, and > > then msm calls drm_atomic_helper_shutdown().

Re: [PATCH] component: Move host device to end of device lists on binding

2021-05-10 Thread Daniel Vetter
On Mon, May 10, 2021 at 7:52 PM Stephen Boyd wrote: > > Quoting Daniel Vetter (2021-05-10 09:05:21) > > On Sat, May 08, 2021 at 12:41:18AM -0700, Stephen Boyd wrote: > > > The device lists are poorly ordered when the component device code is > > > used. This is because component_master_add_with_ma

Re: [PATCH] component: Move host device to end of device lists on binding

2021-05-10 Thread Stephen Boyd
Quoting Daniel Vetter (2021-05-10 09:05:21) > On Sat, May 08, 2021 at 12:41:18AM -0700, Stephen Boyd wrote: > > The device lists are poorly ordered when the component device code is > > used. This is because component_master_add_with_match() returns 0 > > regardless of component devices calling com

Re: [PATCH] component: Move host device to end of device lists on binding

2021-05-10 Thread Daniel Vetter
On Sat, May 08, 2021 at 12:41:18AM -0700, Stephen Boyd wrote: > The device lists are poorly ordered when the component device code is > used. This is because component_master_add_with_match() returns 0 > regardless of component devices calling component_add() first. It can > really only fail if an

Re: [PATCH] component: Move host device to end of device lists on binding

2021-05-10 Thread Rafael J. Wysocki
On Sat, May 8, 2021 at 9:41 AM Stephen Boyd wrote: > > The device lists are poorly ordered when the component device code is > used. This is because component_master_add_with_match() returns 0 > regardless of component devices calling component_add() first. It can > really only fail if an allocati