Re: [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings

2020-09-08 Thread Bartlomiej Zolnierkiewicz
On 8/26/20 10:54 PM, Julia Lawall wrote: > From: kernel test robot > > Use kobj_to_dev() instead of container_of() > > Generated by: scripts/coccinelle/api/kobj_to_dev.cocci > > Fixes: a2fc3718bc22 ("coccinelle: api: add kobj_to_dev.cocci script") > CC: Denis Efremov > Signed-off-by: kernel

Re: [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings

2020-08-29 Thread Markus Elfring
> It seems that 0-day picks up new semantic patches that are added to trees > in kernel.org, but that it's strategy for generating the patch is not > ideal. I'll just drop these Fixes lines. * How do you think about to adjust also the prefix for subjects of generated patches? Another example

Re: [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings

2020-08-28 Thread Julia Lawall
On Thu, 27 Aug 2020, Markus Elfring wrote: > > Generated by: scripts/coccinelle/api/kobj_to_dev.cocci > > > > Fixes: a2fc3718bc22 ("coccinelle: api: add kobj_to_dev.cocci script") > > I wonder about such a combination of information. > > I find it reasonable that two function implementations sho

Re: [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings

2020-08-28 Thread Markus Elfring
> Generated by: scripts/coccinelle/api/kobj_to_dev.cocci > > Fixes: a2fc3718bc22 ("coccinelle: api: add kobj_to_dev.cocci script") I wonder about such a combination of information. I find it reasonable that two function implementations should be adjusted according to a generated patch. Thus I ima