Re: [PATCH] TTM DMA pool v1.8

2011-10-03 Thread Thomas Hellstrom
On 10/03/2011 06:46 PM, Konrad Rzeszutek Wilk wrote: It does now (I had a spinlock mishap).. which reminds me - how do I test these patches with your vmwgfx driver? I've an old version of VMWare Workstation 8, would that do? VMware workstation 8 is OK (it's actually the latest version of

Re: [PATCH] TTM DMA pool v1.8

2011-10-03 Thread Konrad Rzeszutek Wilk
On Mon, Oct 03, 2011 at 06:35:42PM +0200, Thomas Hellstrom wrote: > On 09/30/2011 04:09 PM, Konrad Rzeszutek Wilk wrote: > >On Fri, Sep 30, 2011 at 08:59:52AM +0200, Thomas Hellstrom wrote: > >>Konrad, > >> > >>I'm really sorry for taking so long to review this. > >That is OK. We all are busy - and

Re: [PATCH] TTM DMA pool v1.8

2011-10-03 Thread Thomas Hellstrom
On 09/30/2011 04:09 PM, Konrad Rzeszutek Wilk wrote: On Fri, Sep 30, 2011 at 08:59:52AM +0200, Thomas Hellstrom wrote: Konrad, I'm really sorry for taking so long to review this. That is OK. We all are busy - and it gave me some time to pretty up the code even more. I'd like to

Re: [PATCH] TTM DMA pool v1.8

2011-09-30 Thread Konrad Rzeszutek Wilk
On Fri, Sep 30, 2011 at 08:59:52AM +0200, Thomas Hellstrom wrote: > Konrad, > > I'm really sorry for taking so long to review this. That is OK. We all are busy - and it gave me some time to pretty up the code even more. > > I'd like to go through a couple of high-level things first before > rev

Re: [PATCH] TTM DMA pool v1.8

2011-09-30 Thread Thomas Hellstrom
Konrad, I'm really sorry for taking so long to review this. I'd like to go through a couple of high-level things first before reviewing the coding itself. The page_alloc_func structure looks nice, but I'd like to have it per ttm backend, we would just need to make sure that the backend is al