Re: [PATCH][next] drm/xe/guc: Fix inverted logic on snapshot->copy check

2024-10-10 Thread Thomas Hellström
On Wed, 2024-10-09 at 09:32 -0700, John Harrison wrote: > On 10/9/2024 09:05, Colin Ian King wrote: > > Currently the check to see if snapshot->copy has been allocated is > > inverted and ends up dereferencing snapshot->copy when free'ing > > objects in the array when it is null or not free'ing the

Re: [PATCH][next] drm/xe/guc: Fix inverted logic on snapshot->copy check

2024-10-09 Thread John Harrison
On 10/9/2024 09:05, Colin Ian King wrote: Currently the check to see if snapshot->copy has been allocated is inverted and ends up dereferencing snapshot->copy when free'ing objects in the array when it is null or not free'ing the objects when snapshot->copy is allocated. Fix this by using the cor