Re: [PATCH/RFC] fbdev: Add FOURCC-based format configuration API

2011-08-13 Thread Geert Uytterhoeven
Hi LAurent, On Thu, Aug 11, 2011 at 19:19, Laurent Pinchart wrote: > On Monday 01 August 2011 11:49:46 Geert Uytterhoeven wrote: >> As several of the FOURCC formats duplicate formats you can already specify >> in some other way (e.g. the RGB and greyscale formats), and as FOURCC makes >> life eas

Re: [PATCH/RFC] fbdev: Add FOURCC-based format configuration API

2011-08-11 Thread Laurent Pinchart
Hi Geert, On Monday 01 August 2011 11:49:46 Geert Uytterhoeven wrote: > On Mon, Aug 1, 2011 at 00:54, Florian Tobias Schandinat wrote: > > On 07/31/2011 08:32 PM, Geert Uytterhoeven wrote: > >> On Thu, Jul 28, 2011 at 12:51, Laurent Pinchart wrote: > As for struct fb_var_screeninfo fields to

Re: [PATCH/RFC] fbdev: Add FOURCC-based format configuration API

2011-08-01 Thread Laurent Pinchart
Hi Florian, On Monday 01 August 2011 01:58:27 Florian Tobias Schandinat wrote: > On 07/31/2011 11:28 PM, Laurent Pinchart wrote: > > On Monday 01 August 2011 00:54:48 Florian Tobias Schandinat wrote: > >> On 07/31/2011 08:32 PM, Geert Uytterhoeven wrote: > >>> On Thu, Jul 28, 2011 at 12:51, Lauren

Re: [PATCH/RFC] fbdev: Add FOURCC-based format configuration API

2011-08-01 Thread Geert Uytterhoeven
On Mon, Aug 1, 2011 at 00:54, Florian Tobias Schandinat wrote: > On 07/31/2011 08:32 PM, Geert Uytterhoeven wrote: >> On Thu, Jul 28, 2011 at 12:51, Laurent Pinchart >>  wrote: As for struct fb_var_screeninfo fields to support switching to a FOURCC mode, I also prefer an explicit d

Re: [PATCH/RFC] fbdev: Add FOURCC-based format configuration API

2011-07-31 Thread Florian Tobias Schandinat
Hi Laurent, On 07/31/2011 11:28 PM, Laurent Pinchart wrote: Hi Florian, Thanks for the feedback. On Monday 01 August 2011 00:54:48 Florian Tobias Schandinat wrote: On 07/31/2011 08:32 PM, Geert Uytterhoeven wrote: On Thu, Jul 28, 2011 at 12:51, Laurent Pinchart wrote: As for struct fb_var_s

Re: [PATCH/RFC] fbdev: Add FOURCC-based format configuration API

2011-07-31 Thread Laurent Pinchart
Hi Geert, Thanks for the feedback. On Sunday 31 July 2011 22:32:42 Geert Uytterhoeven wrote: > On Thu, Jul 28, 2011 at 12:51, Laurent Pinchart wrote: > >> As for struct fb_var_screeninfo fields to support switching to a FOURCC > >> mode, I also prefer an explicit dedicated flag to specify switchi

Re: [PATCH/RFC] fbdev: Add FOURCC-based format configuration API

2011-07-31 Thread Laurent Pinchart
Hi Florian, Thanks for the feedback. On Monday 01 August 2011 00:54:48 Florian Tobias Schandinat wrote: > On 07/31/2011 08:32 PM, Geert Uytterhoeven wrote: > > On Thu, Jul 28, 2011 at 12:51, Laurent Pinchart wrote: > >>> As for struct fb_var_screeninfo fields to support switching to a FOURCC > >>

Re: [PATCH/RFC] fbdev: Add FOURCC-based format configuration API

2011-07-31 Thread Florian Tobias Schandinat
On 07/31/2011 08:32 PM, Geert Uytterhoeven wrote: On Thu, Jul 28, 2011 at 12:51, Laurent Pinchart wrote: As for struct fb_var_screeninfo fields to support switching to a FOURCC mode, I also prefer an explicit dedicated flag to specify switching to it. Even though using FOURCC doesn't fit under

Re: [PATCH/RFC] fbdev: Add FOURCC-based format configuration API

2011-07-31 Thread Geert Uytterhoeven
On Thu, Jul 28, 2011 at 12:51, Laurent Pinchart wrote: >> As for struct fb_var_screeninfo fields to support switching to a FOURCC >> mode, I also prefer an explicit dedicated flag to specify switching to it. >> Even though using FOURCC doesn't fit under the notion of a videomode, using >> one of .

Re: [PATCH/RFC] fbdev: Add FOURCC-based format configuration API

2011-07-28 Thread Laurent Pinchart
Hi Guennadi, Thanks for the review. On Thursday 28 July 2011 10:31:24 Guennadi Liakhovetski wrote: > On Mon, 11 Jul 2011, Laurent Pinchart wrote: > > On Friday 24 June 2011 21:45:57 Florian Tobias Schandinat wrote: > > > On 06/24/2011 06:55 PM, Geert Uytterhoeven wrote: > > > > On Fri, Jun 24, 20

Re: [PATCH/RFC] fbdev: Add FOURCC-based format configuration API

2011-07-28 Thread Guennadi Liakhovetski
On Mon, 11 Jul 2011, Laurent Pinchart wrote: > On Friday 24 June 2011 21:45:57 Florian Tobias Schandinat wrote: > > On 06/24/2011 06:55 PM, Geert Uytterhoeven wrote: > > > On Fri, Jun 24, 2011 at 08:19, Paul Mundt wrote: > > >> On Thu, Jun 23, 2011 at 06:08:03PM +0200, Geert Uytterhoeven wrote: >

Re: [PATCH/RFC] fbdev: Add FOURCC-based format configuration API

2011-07-25 Thread Laurent Pinchart
Ping ? As stated in my previous mail, I'd like to reach an agreement on the API, and implement it. I'm fine with either grayscale or nonstd to store the FOURCC (with a slight preference for grayscale), and with either a vmode flag or using the most significant byte of the grayscale/nonstd field

Re: [PATCH/RFC] fbdev: Add FOURCC-based format configuration API

2011-07-11 Thread Laurent Pinchart
On Friday 24 June 2011 21:45:57 Florian Tobias Schandinat wrote: > On 06/24/2011 06:55 PM, Geert Uytterhoeven wrote: > > On Fri, Jun 24, 2011 at 08:19, Paul Mundt wrote: > >> On Thu, Jun 23, 2011 at 06:08:03PM +0200, Geert Uytterhoeven wrote: > >>> On Wed, Jun 22, 2011 at 07:45, Florian Tobias Scha

Re: [PATCH/RFC] fbdev: Add FOURCC-based format configuration API

2011-06-24 Thread Florian Tobias Schandinat
On 06/24/2011 06:55 PM, Geert Uytterhoeven wrote: On Fri, Jun 24, 2011 at 08:19, Paul Mundt wrote: On Thu, Jun 23, 2011 at 06:08:03PM +0200, Geert Uytterhoeven wrote: On Wed, Jun 22, 2011 at 07:45, Florian Tobias Schandinat wrote: On 06/21/2011 10:31 PM, Laurent Pinchart wrote: On Tuesday

Re: [PATCH/RFC] fbdev: Add FOURCC-based format configuration API

2011-06-24 Thread Geert Uytterhoeven
On Fri, Jun 24, 2011 at 08:19, Paul Mundt wrote: > On Thu, Jun 23, 2011 at 06:08:03PM +0200, Geert Uytterhoeven wrote: >> On Wed, Jun 22, 2011 at 07:45, Florian Tobias Schandinat >> wrote: >> > On 06/21/2011 10:31 PM, Laurent Pinchart wrote: >> >> On Tuesday 21 June 2011 22:49:14 Geert Uytterhoev

Re: [PATCH/RFC] fbdev: Add FOURCC-based format configuration API

2011-06-24 Thread Paul Mundt
On Thu, Jun 23, 2011 at 06:08:03PM +0200, Geert Uytterhoeven wrote: > On Wed, Jun 22, 2011 at 07:45, Florian Tobias Schandinat > wrote: > > On 06/21/2011 10:31 PM, Laurent Pinchart wrote: > >> On Tuesday 21 June 2011 22:49:14 Geert Uytterhoeven wrote: > >>> As FOURCC values are always 4 ASCII char

Re: [PATCH/RFC] fbdev: Add FOURCC-based format configuration API

2011-06-23 Thread Geert Uytterhoeven
On Wed, Jun 22, 2011 at 07:45, Florian Tobias Schandinat wrote: > On 06/21/2011 10:31 PM, Laurent Pinchart wrote: >> On Tuesday 21 June 2011 22:49:14 Geert Uytterhoeven wrote: >>> On Tue, Jun 21, 2011 at 17:36, Laurent Pinchart wrote: +The FOURCC-based API replaces format descriptions by four

Re: [PATCH/RFC] fbdev: Add FOURCC-based format configuration API

2011-06-22 Thread Laurent Pinchart
Hi Florian, On Wednesday 22 June 2011 07:45:45 Florian Tobias Schandinat wrote: > On 06/21/2011 10:31 PM, Laurent Pinchart wrote: > > On Tuesday 21 June 2011 22:49:14 Geert Uytterhoeven wrote: > >> On Tue, Jun 21, 2011 at 17:36, Laurent Pinchart wrote: > >>> +The FOURCC-based API replaces format d

Re: [PATCH/RFC] fbdev: Add FOURCC-based format configuration API

2011-06-21 Thread Florian Tobias Schandinat
Hi Geert, Laurent, On 06/21/2011 10:31 PM, Laurent Pinchart wrote: Hi Geert, On Tuesday 21 June 2011 22:49:14 Geert Uytterhoeven wrote: On Tue, Jun 21, 2011 at 17:36, Laurent Pinchart wrote: +The FOURCC-based API replaces format descriptions by four character codes +(FOURCC). FOURCCs are abst

Re: [PATCH/RFC] fbdev: Add FOURCC-based format configuration API

2011-06-21 Thread Laurent Pinchart
Hi Geert, On Tuesday 21 June 2011 22:49:14 Geert Uytterhoeven wrote: > On Tue, Jun 21, 2011 at 17:36, Laurent Pinchart wrote: > > +The following types and visuals are supported. > > + > > +- FB_TYPE_PACKED_PIXELS > > + > > +- FB_TYPE_PLANES > > You forgot FB_TYPE_INTERLEAVED_PLANES, FB_TYPE_TEXT,

Re: [PATCH/RFC] fbdev: Add FOURCC-based format configuration API

2011-06-21 Thread Geert Uytterhoeven
Hi Laurent, On Tue, Jun 21, 2011 at 17:36, Laurent Pinchart wrote: > +The following types and visuals are supported. > + > +- FB_TYPE_PACKED_PIXELS > + > +- FB_TYPE_PLANES You forgot FB_TYPE_INTERLEAVED_PLANES, FB_TYPE_TEXT, and FB_TYPE_VGA_PLANES. Ah, that's the "feel free to extend the API doc