Re: [Intel-gfx] [PATCH 1/8] drm/omap: Simplify the rotation-on-crtc hack

2017-07-31 Thread Tomi Valkeinen
On 31/07/17 14:48, Laurent Pinchart wrote: >>> The comment about read lock is only valid when the plane is bound to the >>> crtc. In general this is not always the case. You can only peak at >>> plane->state when crtc->state->plane_mask & BIT(drm_plane_index(plane)) >>> is true. >>> >>> I think we

Re: [Intel-gfx] [PATCH 1/8] drm/omap: Simplify the rotation-on-crtc hack

2017-07-31 Thread Laurent Pinchart
Hi Daniel, On Tuesday 25 Jul 2017 11:24:28 Daniel Vetter wrote: > On Tue, Jul 25, 2017 at 10:47 AM, Maarten Lankhorst wrote: > > Op 25-07-17 om 10:01 schreef Daniel Vetter: > >> I want/need to rework the core property handling, and this hack is > >> getting in the way. But since it's a non-standar

Re: [Intel-gfx] [PATCH 1/8] drm/omap: Simplify the rotation-on-crtc hack

2017-07-25 Thread Daniel Vetter
On Tue, Jul 25, 2017 at 10:47 AM, Maarten Lankhorst wrote: > Op 25-07-17 om 10:01 schreef Daniel Vetter: >> I want/need to rework the core property handling, and this hack is >> getting in the way. But since it's a non-standard propety only used by >> legacy userspace we know that this will only e

Re: [Intel-gfx] [PATCH 1/8] drm/omap: Simplify the rotation-on-crtc hack

2017-07-25 Thread Maarten Lankhorst
Op 25-07-17 om 10:01 schreef Daniel Vetter: > I want/need to rework the core property handling, and this hack is > getting in the way. But since it's a non-standard propety only used by > legacy userspace we know that this will only every be called from > ioctl code. And never on some other free-st