Re: [PATCH v8 22/24] drm: rockchip: Add VOP2 driver

2022-03-18 Thread Sascha Hauer
Hi Andy, On Thu, Mar 17, 2022 at 03:23:12PM +0800, Andy Yan wrote: >I found a obvious  error in 0x604(OVERLAY_LAYER_SEL) register, the >configuration value > >is 0x54763513. > >I am not sure if you know clearly about this register: > >Every four bits of this register select

Re: [PATCH v8 22/24] drm: rockchip: Add VOP2 driver

2022-03-17 Thread Andy Yan
Hi Sascha: On 3/16/22 20:22, Andy Yan wrote: Hi Sascha and Daniel: On 3/16/22 15:40, Sascha Hauer wrote: On Tue, Mar 15, 2022 at 02:46:35PM +0800, Andy Yan wrote: Hi Sascha: On 3/11/22 16:33, Sascha Hauer wrote: From: Andy Yan The VOP2 unit is found on Rockchip SoCs beginning with rk3566/

Re: [PATCH v8 22/24] drm: rockchip: Add VOP2 driver

2022-03-16 Thread Andy Yan
Hi Sascha and Daniel: On 3/16/22 15:40, Sascha Hauer wrote: On Tue, Mar 15, 2022 at 02:46:35PM +0800, Andy Yan wrote: Hi Sascha: On 3/11/22 16:33, Sascha Hauer wrote: From: Andy Yan The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568. It replaces the VOP unit found in the ol

Re: [PATCH v8 22/24] drm: rockchip: Add VOP2 driver

2022-03-16 Thread Sascha Hauer
On Tue, Mar 15, 2022 at 02:46:35PM +0800, Andy Yan wrote: > Hi Sascha: > > On 3/11/22 16:33, Sascha Hauer wrote: > > From: Andy Yan > > > > The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568. > > It replaces the VOP unit found in the older Rockchip SoCs. > > > > This driver ha

Re: [PATCH v8 22/24] drm: rockchip: Add VOP2 driver

2022-03-15 Thread Andy Yan
Hi Daniel: On 3/15/22 20:43, Daniel Stone wrote: Hi Andy, On Tue, 15 Mar 2022 at 06:46, Andy Yan wrote: On 3/11/22 16:33, Sascha Hauer wrote: The driver is tested with HDMI and MIPI-DSI display on a RK3568-EVB board. Overlay support is tested with the modetest utility. AFBC support on the cl

Re: [PATCH v8 22/24] drm: rockchip: Add VOP2 driver

2022-03-15 Thread Daniel Stone
Hi Andy, On Tue, 15 Mar 2022 at 06:46, Andy Yan wrote: > On 3/11/22 16:33, Sascha Hauer wrote: > > The driver is tested with HDMI and MIPI-DSI display on a RK3568-EVB > > board. Overlay support is tested with the modetest utility. AFBC support > > on the cluster windows is tested with weston-simp

Re: [PATCH v8 22/24] drm: rockchip: Add VOP2 driver

2022-03-14 Thread Andy Yan
Hi Sascha: On 3/11/22 16:33, Sascha Hauer wrote: From: Andy Yan The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568. It replaces the VOP unit found in the older Rockchip SoCs. This driver has been derived from the downstream Rockchip Kernel and heavily modified: - All nonsta

Re:[PATCH v8 22/24] drm: rockchip: Add VOP2 driver

2022-03-14 Thread 黄家钗
Hi Sascha Hauer From: Sascha Hauer Date: 2022-03-11 16:33:21 To: dri-devel@lists.freedesktop.org Cc: linux-arm-ker...@lists.infradead.org,linux-rockc...@lists.infradead.org,devicet...@vger.kernel.org,ker...@pengutronix.de,Andy Yan ,Benjamin Gaignard ,Michael Riesch ,Sandy Huang ,"Heiko St