Re: Radeon regression fix

2011-10-01 Thread Brad Campbell
On 29/09/11 22:36, Alex Deucher wrote: On Thu, Sep 29, 2011 at 10:21 AM, Brad Campbell wrote: This patch fixes a regression introduced between 2.6.39& 3.1-rc1 whereby the displayport AUX channel stopped re-trying commands that elicited a DEFER response. It should still be retrying, just res

Re: Radeon regression fix

2011-10-01 Thread Brad Campbell
On 29/09/11 22:36, Alex Deucher wrote: On Thu, Sep 29, 2011 at 10:21 AM, Brad Campbell wrote: This patch fixes a regression introduced between 2.6.39& 3.1-rc1 whereby the displayport AUX channel stopped re-trying commands that elicited a DEFER response. It should still be retrying, just rest

Radeon regression fix

2011-10-01 Thread Brad Campbell
This patch fixes a regression introduced between 2.6.39 & 3.1-rc1 whereby the displayport AUX channel stopped re-trying commands that elicited a DEFER response. Signed-off-by: Brad Campbell diff --git a/drivers/gpu/drm/radeon/atombios_dp.c b/drivers/gpu/drm/radeon/atombios_dp.c index 7ad43c

Radeon regression fix

2011-09-30 Thread Brad Campbell
On 30/09/11 12:59, Alex Deucher wrote: > On Thu, Sep 29, 2011 at 8:23 PM, Brad Campbell >> Looking at it with a nights sleep, it's obvious the code path in >> aux_native_write is ok. Is this a bit cleaner than the last patch? > > Looks pretty good. I was thinking of something more like this (sorr

Radeon regression fix

2011-09-30 Thread Brad Campbell
On 29/09/11 23:21, Brad Campbell wrote: > On 29/09/11 22:36, Alex Deucher wrote: >> On Thu, Sep 29, 2011 at 10:21 AM, Brad Campbell >> wrote: >>> This patch fixes a regression introduced between 2.6.39& 3.1-rc1 whereby >>> the displayport AUX channel stopped re-trying commands that elicited >>> a D

Radeon regression fix

2011-09-30 Thread Alex Deucher
On Fri, Sep 30, 2011 at 1:14 AM, Brad Campbell wrote: > On 30/09/11 12:59, Alex Deucher wrote: >> >> On Thu, Sep 29, 2011 at 8:23 PM, Brad Campbell > >>> Looking at it with a nights sleep, it's obvious the code path in >>> aux_native_write is ok. Is this a bit cleaner than the last patch? >> >> Lo

Radeon regression fix

2011-09-30 Thread Alex Deucher
On Thu, Sep 29, 2011 at 8:23 PM, Brad Campbell wrote: > On 29/09/11 23:21, Brad Campbell wrote: >> >> On 29/09/11 22:36, Alex Deucher wrote: >>> >>> On Thu, Sep 29, 2011 at 10:21 AM, Brad Campbell >>> wrote: This patch fixes a regression introduced between 2.6.39& 3.1-rc1 whereby th

Radeon regression fix

2011-09-29 Thread Brad Campbell
On 29/09/11 22:36, Alex Deucher wrote: > On Thu, Sep 29, 2011 at 10:21 AM, Brad Campbell > wrote: >> This patch fixes a regression introduced between 2.6.39& 3.1-rc1 whereby >> the displayport AUX channel stopped re-trying commands that elicited a DEFER >> response. >> > > It should still be ret

Radeon regression fix

2011-09-29 Thread Brad Campbell
On 29/09/11 22:36, Alex Deucher wrote: > On Thu, Sep 29, 2011 at 10:21 AM, Brad Campbell > wrote: >> This patch fixes a regression introduced between 2.6.39& 3.1-rc1 whereby >> the displayport AUX channel stopped re-trying commands that elicited a DEFER >> response. >> > It should still be retry

Re: Radeon regression fix

2011-09-29 Thread Alex Deucher
On Fri, Sep 30, 2011 at 1:14 AM, Brad Campbell wrote: > On 30/09/11 12:59, Alex Deucher wrote: >> >> On Thu, Sep 29, 2011 at 8:23 PM, Brad Campbell > >>> Looking at it with a nights sleep, it's obvious the code path in >>> aux_native_write is ok. Is this a bit cleaner than the last patch? >> >> Lo

Radeon regression fix

2011-09-29 Thread Brad Campbell
This patch fixes a regression introduced between 2.6.39 & 3.1-rc1 whereby the displayport AUX channel stopped re-trying commands that elicited a DEFER response. Signed-off-by: Brad Campbell diff --git a/drivers/gpu/drm/radeon/atombios_dp.c b/drivers/gpu/drm/radeon/atombios_dp.c index 7ad43c6.

Re: Radeon regression fix

2011-09-29 Thread Brad Campbell
On 30/09/11 12:59, Alex Deucher wrote: On Thu, Sep 29, 2011 at 8:23 PM, Brad Campbell Looking at it with a nights sleep, it's obvious the code path in aux_native_write is ok. Is this a bit cleaner than the last patch? Looks pretty good. I was thinking of something more like this (sorry for

Re: Radeon regression fix

2011-09-29 Thread Alex Deucher
On Thu, Sep 29, 2011 at 8:23 PM, Brad Campbell wrote: > On 29/09/11 23:21, Brad Campbell wrote: >> >> On 29/09/11 22:36, Alex Deucher wrote: >>> >>> On Thu, Sep 29, 2011 at 10:21 AM, Brad Campbell >>> wrote: This patch fixes a regression introduced between 2.6.39& 3.1-rc1 whereby th

Re: Radeon regression fix

2011-09-29 Thread Brad Campbell
On 29/09/11 23:21, Brad Campbell wrote: On 29/09/11 22:36, Alex Deucher wrote: On Thu, Sep 29, 2011 at 10:21 AM, Brad Campbell wrote: This patch fixes a regression introduced between 2.6.39& 3.1-rc1 whereby the displayport AUX channel stopped re-trying commands that elicited a DEFER response.

Radeon regression fix

2011-09-29 Thread Alex Deucher
On Thu, Sep 29, 2011 at 10:21 AM, Brad Campbell wrote: > This patch fixes a regression introduced between 2.6.39 & 3.1-rc1 whereby > the displayport AUX channel stopped re-trying commands that elicited a DEFER > response. > It should still be retrying, just restructured slightly. The retry logic

Re: Radeon regression fix

2011-09-29 Thread Alex Deucher
On Thu, Sep 29, 2011 at 10:21 AM, Brad Campbell wrote: > This patch fixes a regression introduced between 2.6.39 & 3.1-rc1 whereby > the displayport AUX channel stopped re-trying commands that elicited a DEFER > response. > It should still be retrying, just restructured slightly. The retry logic