RE: Review request to DRM Driver for Samsung SoC Exynos4210.

2011-08-30 Thread Inki Dae
ung.com; dri- > de...@lists.freedesktop.org; kyungmin.p...@samsung.com > Subject: Re: Review request to DRM Driver for Samsung SoC Exynos4210. > > On Tue, Aug 30, 2011 at 7:38 AM, Inki Dae wrote: > > > >> > Basically gem_dumb_* and gem_* are same operation. The difference

Re: Review request to DRM Driver for Samsung SoC Exynos4210.

2011-08-30 Thread Rob Clark
On Tue, Aug 30, 2011 at 7:38 AM, Inki Dae wrote: > >> > Basically gem_dumb_* and gem_* are same operation. The difference >> between >> > them is that gem_dumb_ needs framebuffer information such width, height >> and >> > bpp to allocate buffer and gem_ needs only size. in case of gem_dumb_, >> si

RE: Review request to DRM Driver for Samsung SoC Exynos4210.

2011-08-30 Thread Inki Dae
samsung.com; eric.y.m...@gmail.com; r...@ti.com > Subject: Re: Review request to DRM Driver for Samsung SoC Exynos4210. > > >> 2. I'm not sure why samsung_drm_fn_encoder exists, it looks like from > >> the crtc mode set functions you call the encoder mode set fu

Re: Review request to DRM Driver for Samsung SoC Exynos4210.

2011-08-30 Thread Dave Airlie
>> 2. I'm not sure why samsung_drm_fn_encoder exists, it looks like from >> the crtc mode set functions you call the encoder mode set functions, >> is it not possible to use the helper drm_crtc_helper_set_mode so that >> the crtc mode set is called then the encoder ones without having the >> explic

RE: Review request to DRM Driver for Samsung SoC Exynos4210.

2011-08-29 Thread Inki Dae
ts.freedesktop.org > Subject: Re: Review request to DRM Driver for Samsung SoC Exynos4210. > > > I had sent DRM Driver for Samsung SoC Exynos4210 over the three times. > > > > But I didn't received any comments from you. > > I was sort of hoping someone else would t

RE: Review request to DRM Driver for Samsung SoC Exynos4210.

2011-08-29 Thread Kyungmin Park
; kyungmin.p...@samsung.com; dri-devel@lists.freedesktop.org Subject: Re: Review request to DRM Driver for Samsung SoC Exynos4210. > I had sent DRM Driver for Samsung SoC Exynos4210 over the three times. > > But I didn't received any comments from you. I was sort of hoping someone els

Re: Review request to DRM Driver for Samsung SoC Exynos4210.

2011-08-29 Thread Dave Airlie
> I had sent DRM Driver for Samsung SoC Exynos4210 over the three times. > > But I didn’t received any comments from you. I was sort of hoping someone else would take a look at these ARM drivers before me, it might be worth getting some inter-company review between the vendors submitting drm compo