Re: [PATCH v6 01/12] spi: add driver for intel graphics on-die spi device

2024-09-25 Thread Mark Brown
On Wed, Sep 25, 2024 at 12:31:34PM +, Usyskin, Alexander wrote: > > It's locking/refcounting stuff that looks nothing like any other SPI > > controller driver. Even if it works it's obviously fragile since the > > driver does surprising things which break assumptions that will be made > > by

RE: [PATCH v6 01/12] spi: add driver for intel graphics on-die spi device

2024-09-25 Thread Usyskin, Alexander
> On Sat, Sep 21, 2024 at 01:00:52PM +, Winkler, Tomas wrote: > > > On Thu, Sep 19, 2024 at 09:54:24AM +, Winkler, Tomas wrote: > > > > > On Mon, Sep 16, 2024 at 04:49:17PM +0300, Alexander Usyskin > wrote: > > > > Just do normal open coded allocations, the reference counting is just > > >

Re: [PATCH v6 01/12] spi: add driver for intel graphics on-die spi device

2024-09-23 Thread Mark Brown
On Sat, Sep 21, 2024 at 01:00:52PM +, Winkler, Tomas wrote: > > On Thu, Sep 19, 2024 at 09:54:24AM +, Winkler, Tomas wrote: > > > > On Mon, Sep 16, 2024 at 04:49:17PM +0300, Alexander Usyskin wrote: > > Just do normal open coded allocations, the reference counting is just > > obscure. > T

Re: [PATCH v6 01/12] spi: add driver for intel graphics on-die spi device

2024-09-23 Thread Tvrtko Ursulin
On 21/09/2024 14:00, Winkler, Tomas wrote: On Thu, Sep 19, 2024 at 09:54:24AM +, Winkler, Tomas wrote: On Mon, Sep 16, 2024 at 04:49:17PM +0300, Alexander Usyskin wrote: @@ -0,0 +1,142 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright(c) 2019-2024, Intel Corporation. All rig

RE: [PATCH v6 01/12] spi: add driver for intel graphics on-die spi device

2024-09-21 Thread Winkler, Tomas
> > On Thu, Sep 19, 2024 at 09:54:24AM +, Winkler, Tomas wrote: > > > On Mon, Sep 16, 2024 at 04:49:17PM +0300, Alexander Usyskin wrote: > > > > > @@ -0,0 +1,142 @@ > > > > +// SPDX-License-Identifier: GPL-2.0 > > > > +/* > > > > + * Copyright(c) 2019-2024, Intel Corporation. All rights re

Re: [PATCH v6 01/12] spi: add driver for intel graphics on-die spi device

2024-09-19 Thread Mark Brown
On Thu, Sep 19, 2024 at 09:54:24AM +, Winkler, Tomas wrote: > > On Mon, Sep 16, 2024 at 04:49:17PM +0300, Alexander Usyskin wrote: > > > @@ -0,0 +1,142 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > > +/* > > > + * Copyright(c) 2019-2024, Intel Corporation. All rights reserved. > > > + */

RE: [PATCH v6 01/12] spi: add driver for intel graphics on-die spi device

2024-09-19 Thread Winkler, Tomas
> > On Mon, Sep 16, 2024 at 04:49:17PM +0300, Alexander Usyskin wrote: > > > Add auxiliary driver for intel discrete graphics on-die spi device. > > This doesn't actually do anything AFAICT? It doesn't register with any > subsystem or anything. Please don't submit empty boilerplate like this

Re: [PATCH v6 01/12] spi: add driver for intel graphics on-die spi device

2024-09-18 Thread Mark Brown
On Mon, Sep 16, 2024 at 04:49:17PM +0300, Alexander Usyskin wrote: > Add auxiliary driver for intel discrete graphics > on-die spi device. This doesn't actually do anything AFAICT? It doesn't register with any subsystem or anything. Please don't submit empty boilerplate like this, submit a driv