Re: [PATCH 9/9] drm/verisilicon: Add starfive hdmi driver

2023-06-25 Thread Keith Zhao
yes I tested modetest -M starfive -D 0 -s 116@31:1280x720-59.94 -v modetest -M starfive -D 0 -s 116@31:1920x1080 -v and the second command will repeat the problem as you advise at the beginning I call the "starfive_hdmi_setup" function in the "starfive_hdmi_encoder_enable" instead of "starfive_h

RE: [PATCH 9/9] drm/verisilicon: Add starfive hdmi driver

2023-06-22 Thread Hoegeun Kwon
Hi Keith, There is a problem with stopping when changing modes. Below test log root:~> modetest -Mstarfive -c Connectors: id encoder status namesize (mm) modes encoders 116 115 connected HDMI-A-1320x180 51 115 modes: in

Re: [PATCH 9/9] drm/verisilicon: Add starfive hdmi driver

2023-06-05 Thread Maxime Ripard
Hi, On Fri, Jun 02, 2023 at 03:40:43PM +0800, Keith Zhao wrote: > Add HDMI dirver for StarFive SoC JH7110. > > Signed-off-by: Keith Zhao I have a few high level comments: > +static int starfive_hdmi_setup(struct starfive_hdmi *hdmi, > +struct drm_display_mode *mode)

Re: [PATCH 9/9] drm/verisilicon: Add starfive hdmi driver

2023-06-05 Thread Philipp Zabel
Hi Keith, On Fri, Jun 02, 2023 at 03:40:43PM +0800, Keith Zhao wrote: > Add HDMI dirver for StarFive SoC JH7110. > > Signed-off-by: Keith Zhao > --- > drivers/gpu/drm/verisilicon/Kconfig | 11 + > drivers/gpu/drm/verisilicon/Makefile| 1 + > drivers/gpu/drm/verisilicon/starfi