RE: [PATCH 2/2 v4] drm/exynos: added userptr feature.

2012-05-16 Thread Inki Dae
sung.com; > sw0312@samsung.com; jy0922.s...@samsung.com > Subject: Re: [PATCH 2/2 v4] drm/exynos: added userptr feature. > > On Tue, May 15, 2012 at 12:33 AM, Inki Dae wrote: > > Hi Jerome, > > > >> -Original Message- > >> From: Jerome Glisse [m

Re: [PATCH 2/2 v4] drm/exynos: added userptr feature.

2012-05-15 Thread Jerome Glisse
minc...@kernel.org; >> kosaki.motoh...@gmail.com; kyungmin.p...@samsung.com; >> sw0312@samsung.com; jy0922.s...@samsung.com >> Subject: Re: [PATCH 2/2 v4] drm/exynos: added userptr feature. >> >> On Mon, May 14, 2012 at 2:17 AM, Inki Dae wrote: >> > t

Re: [PATCH 2/2 v4] drm/exynos: added userptr feature.

2012-05-14 Thread KOSAKI Motohiro
; sw0312@samsung.com; jy0922.s...@samsung.com Subject: Re: [PATCH 2/2 v4] drm/exynos: added userptr feature. + npages = buf->size>> PAGE_SHIFT; Why round down? usually we use round up. The size was already rounded up by exynos_drm_gem_userptr_ioctl so this is just used to get p

RE: [PATCH 2/2 v4] drm/exynos: added userptr feature.

2012-05-14 Thread Inki Dae
sung.com; > sw0312@samsung.com; jy0922.s...@samsung.com > Subject: Re: [PATCH 2/2 v4] drm/exynos: added userptr feature. > > On Mon, May 14, 2012 at 2:17 AM, Inki Dae wrote: > > this feature is used to import user space region allocated by malloc() > or > > mmaped into a gem.

Re: [PATCH 2/2 v4] drm/exynos: added userptr feature.

2012-05-14 Thread Jerome Glisse
On Mon, May 14, 2012 at 2:17 AM, Inki Dae wrote: > this feature is used to import user space region allocated by malloc() or > mmaped into a gem. for this, we uses get_user_pages() to get all the pages > to VMAs within user address space. However we should pay attention to use > this userptr featu

RE: [PATCH 2/2 v4] drm/exynos: added userptr feature.

2012-05-14 Thread Inki Dae
nc...@kernel.org; kyungmin.p...@samsung.com; > sw0312@samsung.com; jy0922.s...@samsung.com > Subject: Re: [PATCH 2/2 v4] drm/exynos: added userptr feature. > > (5/14/12 2:52 AM), Inki Dae wrote: > > > > > >> -Original Message- > >> From: KOSAKI Motohiro [mai

RE: [PATCH 2/2 v4] drm/exynos: added userptr feature.

2012-05-14 Thread Inki Dae
n.p...@samsung.com; > sw0312@samsung.com; jy0922.s...@samsung.com > Subject: Re: [PATCH 2/2 v4] drm/exynos: added userptr feature. > > (5/14/12 2:52 AM), Inki Dae wrote: > > > > > >> -Original Message- > >> From: KOSAKI Motohiro [mailto:kosaki.mot

RE: [PATCH 2/2 v4] drm/exynos: added userptr feature.

2012-05-13 Thread Inki Dae
12@samsung.com; > jy0922.s...@samsung.com > Subject: Re: [PATCH 2/2 v4] drm/exynos: added userptr feature. > > > +       npages = buf->size >> PAGE_SHIFT; > > Why round down? usually we use round up. > The size was already rounded up by exynos_drm_gem_u

Re: [PATCH 2/2 v4] drm/exynos: added userptr feature.

2012-05-13 Thread KOSAKI Motohiro
> +       npages = buf->size >> PAGE_SHIFT; Why round down? usually we use round up. > +       down_read(¤t->mm->mmap_sem); > + > +       /* > +        * Basically, all the pages from get_user_pages() can not be not only > +        * migrated by CMA but also swapped out. > +        * > +