Re: [PATCH 2/2] drm: get lock before accessing vblank refcount

2022-09-06 Thread Daniel Vetter
On Tue, Sep 06, 2022 at 08:18:30PM +, Li, Yunxiang (Teddy) wrote: > [Public] > > Hi Daniel, > > I added the check because I saw that the refcount was always > updated/read with lock held elsewhere, and the pattern looked very > similar to in the put e.g. drm_crtc_vblank_reset. This patchset i

RE: [PATCH 2/2] drm: get lock before accessing vblank refcount

2022-09-06 Thread Li, Yunxiang (Teddy)
[Public] Hi Daniel, I added the check because I saw that the refcount was always updated/read with lock held elsewhere, and the pattern looked very similar to in the put e.g. drm_crtc_vblank_reset. This patchset is outdated by now and I've sent a fix to amd-gfx for the specific issue in amdgpu

Re: [PATCH 2/2] drm: get lock before accessing vblank refcount

2022-09-06 Thread Daniel Vetter
On Fri, Jul 22, 2022 at 05:52:34PM -0400, Yunxiang Li wrote: > Acquire vbl_lock before accessing vblank refcount in drm_vblank_put, > just like everywhere else that access the refcount. > > Signed-off-by: Yunxiang Li The entire point of using atomic for the refcount is that we can check it lockl