Re: [PATCH] drm/xe: Fix NPD when saving default context

2025-05-29 Thread Lucas De Marchi
On Wed, May 28, 2025 at 11:55:03PM -0500, Upadhyay, Tejas wrote: @@ -114,7 +114,7 @@ struct xe_sched_job *xe_sched_job_create(struct xe_exec_queue *q, xe_exec_queue_get(job->q); err = drm_sched_job_init(&job->drm, q->entity, 1, NULL, -q->xef->drm->

Re: [PATCH] drm/xe: Fix NPD when saving default context

2025-05-29 Thread Lucas De Marchi
On Wed, May 28, 2025 at 02:51:33PM -0700, Matthew Brost wrote: On Wed, May 28, 2025 at 02:42:22PM -0700, Lucas De Marchi wrote: xef is only valid if it's a job from userspace. For in-kernel jobs it causes a NPD like below: <4> [] RIP: 0010:xe_sched_job_create+0xbd/0x390 [xe] ..

Re: [PATCH] drm/xe: Fix NPD when saving default context

2025-05-28 Thread Matthew Brost
On Wed, May 28, 2025 at 10:55:03PM -0600, Upadhyay, Tejas wrote: > > > > -Original Message- > > From: Intel-xe On Behalf Of Lucas > > De Marchi > > Sent: 29 May 2025 03:12 > > To: intel...@lists.freedesktop.org > > Cc: Brost, Matthew ; dri- > > de...@lists.freedesktop.org; De Marchi, Luc

RE: [PATCH] drm/xe: Fix NPD when saving default context

2025-05-28 Thread Upadhyay, Tejas
> -Original Message- > From: Intel-xe On Behalf Of Lucas > De Marchi > Sent: 29 May 2025 03:12 > To: intel...@lists.freedesktop.org > Cc: Brost, Matthew ; dri- > de...@lists.freedesktop.org; De Marchi, Lucas ; > Christian König ; Pierre-Eric Pelloux-Prayer > ; Philipp Stanner > > Subjec

Re: [PATCH] drm/xe: Fix NPD when saving default context

2025-05-28 Thread Matthew Brost
On Wed, May 28, 2025 at 02:42:22PM -0700, Lucas De Marchi wrote: > xef is only valid if it's a job from userspace. For in-kernel jobs it > causes a NPD like below: > > <4> [] RIP: 0010:xe_sched_job_create+0xbd/0x390 [xe] > ... > <4> [] Call Trace: > <4> [] >