RE: [PATCH] drm/virtio: Create Dumb BOs as guest Blobs (v2)

2021-04-12 Thread Zhang, Tina
> -Original Message- > From: Gurchetan Singh > Sent: Tuesday, April 13, 2021 8:58 AM > To: Gerd Hoffmann > Cc: Kasireddy, Vivek ; ML dri-devel de...@lists.freedesktop.org>; Zhang, Tina > Subject: Re: [PATCH] drm/virtio: Create Dumb BOs as guest Blobs (v2) >

Re: [PATCH] drm/virtio: Create Dumb BOs as guest Blobs (v2)

2021-04-12 Thread Gurchetan Singh
On Fri, Apr 9, 2021 at 12:48 AM Gerd Hoffmann wrote: > Hi, > > > > IIRC the VIRTGPU_BLOB_FLAG_USE_SHAREABLE flag means that the host *can* > > > create a shared mapping (i.e. the host seeing guest-side changes > without > > > explicit transfer doesn't cause problems for the guest). It doesn no

Re: [PATCH] drm/virtio: Create Dumb BOs as guest Blobs (v2)

2021-04-09 Thread Gerd Hoffmann
Hi, > > IIRC the VIRTGPU_BLOB_FLAG_USE_SHAREABLE flag means that the host *can* > > create a shared mapping (i.e. the host seeing guest-side changes without > > explicit transfer doesn't cause problems for the guest). It doesn not > > mean the host *must* create a shared mapping (note that ther

Re: [PATCH] drm/virtio: Create Dumb BOs as guest Blobs (v2)

2021-04-08 Thread Gurchetan Singh
On Thu, Apr 8, 2021 at 2:27 AM Gerd Hoffmann wrote: > > > + > > > + if (vgdev->has_resource_blob) { > > > + params.blob_mem = VIRTGPU_BLOB_MEM_GUEST; > > > + params.blob_flags = VIRTGPU_BLOB_FLAG_USE_SHAREABLE; > > > > > > > This creates some log spam with crosvm

Re: [PATCH] drm/virtio: Create Dumb BOs as guest Blobs (v2)

2021-04-08 Thread Gerd Hoffmann
> > + > > + if (vgdev->has_resource_blob) { > > + params.blob_mem = VIRTGPU_BLOB_MEM_GUEST; > > + params.blob_flags = VIRTGPU_BLOB_FLAG_USE_SHAREABLE; > > > > This creates some log spam with crosvm + virgl_3d + vanilla linux, since > transfers don't work for guest

Re: [PATCH] drm/virtio: Create Dumb BOs as guest Blobs (v2)

2021-04-06 Thread Gurchetan Singh
On Tue, Apr 6, 2021 at 1:47 PM Vivek Kasireddy wrote: > If support for Blob resources is available, then dumb BOs created > by the driver can be considered as guest Blobs. > > v2: Don't skip transfer and flush commands as part of plane update > as the device may have created a shared mapping. (Ge